Skip to content

Temporal bump and implementation of toPlainYearMonth and toPlainMonthDay#4207

Merged
nekevss merged 6 commits intoboa-dev:mainfrom
lockels:main
Mar 14, 2025
Merged

Temporal bump and implementation of toPlainYearMonth and toPlainMonthDay#4207
nekevss merged 6 commits intoboa-dev:mainfrom
lockels:main

Conversation

@lockels
Copy link
Contributor

@lockels lockels commented Mar 14, 2025

This Pull Request fixes/closes #{issue_num}.

It changes the following:

  • Bump temporal and adapt the corresponding function calls in the engine:)
  • Implement functions PlainDate.prototype.toPlainMonthDay and PlainDate.prototype.toPlainYearMonth

@lockels lockels marked this pull request as draft March 14, 2025 11:46
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 52.63%. Comparing base (6ddc2b4) to head (ac1299e).
Report is 393 commits behind head on main.

Files with missing lines Patch % Lines
...ore/engine/src/builtins/temporal/plain_date/mod.rs 0.00% 14 Missing ⚠️
core/engine/src/builtins/temporal/duration/mod.rs 0.00% 1 Missing ⚠️
...ngine/src/builtins/temporal/plain_month_day/mod.rs 0.00% 1 Missing ⚠️
...gine/src/builtins/temporal/plain_year_month/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4207      +/-   ##
==========================================
+ Coverage   47.24%   52.63%   +5.38%     
==========================================
  Files         476      487      +11     
  Lines       46892    51960    +5068     
==========================================
+ Hits        22154    27348    +5194     
+ Misses      24738    24612     -126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lockels lockels marked this pull request as ready for review March 14, 2025 11:59
@lockels lockels changed the title Temporal bump Temporal bump and implementation of toPlainYearMonth and toPlainMonthDay Mar 14, 2025
@nekevss
Copy link
Member

nekevss commented Mar 14, 2025

For reference:

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,615 46,656 +41
Ignored 1,634 1,634 0
Panics 0 0 0
Fixed tests (41):
test/staging/Intl402/Temporal/old/duration-arithmetic-dst.js (previously Failed)
test/staging/Temporal/Duration/old/balances-up-to-next-unit-after-rounding.js (previously Failed)
test/staging/Temporal/Duration/old/balances-differently-depending-on-relativeto.js (previously Failed)
test/staging/Temporal/Duration/old/accepts-datetime-strings-or-fields-for-relativeTo.js (previously Failed)
test/intl402/Temporal/Duration/prototype/total/dst-rounding-result.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainMonthDay/branding.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainMonthDay/basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/argument-plaindatetime.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainYearMonth/limits.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainYearMonth/branding.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainYearMonth/basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/argument-plaindatetime.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-plaindate.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-plaindate.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/argument-zoneddatetime.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/argument-zoneddatetime.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/total-of-each-unit-relativeto.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-2.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/balance-negative-result.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/duration-out-of-range-added-to-relativeto.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/incorrect-properties-ignored.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-no-time-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-string-zoneddatetime.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-string-plaindatetime.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/balances-days-up-to-both-years-and-months.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/balance-subseconds.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-wrong-type.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/rounds-durations-with-calendar-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/unit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-5.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-zoneddatetime-with-fractional-days.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/unit-string-shorthand-string.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/rounds-calendar-units-in-durations-without-calendar-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/unit-plurals-accepted-string.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/no-precision-loss-for-small-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-zoneddatetime-negative-epochnanoseconds.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-timezone-string.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-1.js (previously Failed)

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great

@nekevss nekevss added this pull request to the merge queue Mar 14, 2025
Merged via the queue into boa-dev:main with commit c147265 Mar 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants