Skip to content

Temporal bump#4231

Merged
nekevss merged 2 commits intoboa-dev:mainfrom
lockels:main
Apr 25, 2025
Merged

Temporal bump#4231
nekevss merged 2 commits intoboa-dev:mainfrom
lockels:main

Conversation

@lockels
Copy link
Contributor

@lockels lockels commented Apr 25, 2025

This Pull Request fixes/closes #{issue_num}.

It changes the following:

  • Bump temoral.rs to latest version. Current commit hash is over a month old
  • Was on this updated version to use the boa tester locally for a while, and decided to submit it :)

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 52.47%. Comparing base (6ddc2b4) to head (6602f6c).
Report is 402 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/builtins/temporal/options.rs 0.00% 14 Missing ⚠️
...ngine/src/builtins/temporal/plain_date_time/mod.rs 0.00% 4 Missing ⚠️
core/engine/src/builtins/temporal/duration/mod.rs 0.00% 3 Missing ⚠️
core/engine/src/builtins/temporal/instant/mod.rs 0.00% 3 Missing ⚠️
...ore/engine/src/builtins/temporal/plain_time/mod.rs 0.00% 3 Missing ⚠️
.../engine/src/builtins/temporal/zoneddatetime/mod.rs 0.00% 2 Missing ⚠️
core/engine/src/builtins/temporal/now.rs 0.00% 1 Missing ⚠️
...gine/src/builtins/temporal/plain_year_month/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4231      +/-   ##
==========================================
+ Coverage   47.24%   52.47%   +5.23%     
==========================================
  Files         476      487      +11     
  Lines       46892    51597    +4705     
==========================================
+ Hits        22154    27076    +4922     
+ Misses      24738    24521     -217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the bump and changes

@nekevss
Copy link
Member

nekevss commented Apr 25, 2025

Thanks for doing the ground work on this. I've been a bit busy with some of the more recent updates to get to it 😅

@nekevss nekevss added this pull request to the merge queue Apr 25, 2025
Merged via the queue into boa-dev:main with commit ccfe59d Apr 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants