Skip to content

Enable PlainDate.prototype.toZonedDateTime method#4233

Merged
nekevss merged 2 commits intomainfrom
enable-pd-tozoneddatetime
Apr 29, 2025
Merged

Enable PlainDate.prototype.toZonedDateTime method#4233
nekevss merged 2 commits intomainfrom
enable-pd-tozoneddatetime

Conversation

@nekevss
Copy link
Member

@nekevss nekevss commented Apr 28, 2025

This Pull Request is related to the ongoing work for #1804 and #4071.

Briefly looking over the test262 results locally, the remaining failing tests for this suite should be related to similar parsing bugs for other methods, and should be fixed with subsequent temporal_rs updates.

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,761 46,778 +17
Ignored 1,634 1,634 0
Failed 1,859 1,842 -17
Panics 0 0 0
Conformance 93.05% 93.08% +0.03%
Fixed tests (17):
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-zoneddatetime-negative-epochnanoseconds.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-with-time-designator.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/plaintime-argument-zoneddatetime-balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/plaintime-propertybag-no-time-units.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-string.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/order-of-operations.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/toZonedDateTime/timezone-string-datetime.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/toZonedDateTime/dst-skipped-cross-midnight.js (previously Failed)

@nekevss nekevss added this pull request to the merge queue Apr 29, 2025
@nekevss nekevss added the C-Builtins PRs and Issues related to builtins/intrinsics label Apr 29, 2025
Merged via the queue into main with commit ba56c53 Apr 29, 2025
14 checks passed
@nekevss nekevss deleted the enable-pd-tozoneddatetime branch April 29, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants