Skip to content

PlainDateTime::toZonedDateTime & PlainDateTime::toPlainDate implementations#4234

Merged
nekevss merged 1 commit intomainfrom
impl-remaining-temporal-methods
Apr 30, 2025
Merged

PlainDateTime::toZonedDateTime & PlainDateTime::toPlainDate implementations#4234
nekevss merged 1 commit intomainfrom
impl-remaining-temporal-methods

Conversation

@nekevss
Copy link
Member

@nekevss nekevss commented Apr 30, 2025

This Pull Request is related to #1804 and #4072.

These were missed with the change from yesterday. With these methods activated, I believe that there is only one last method ZonedDateTime::round to be implemented in Boa from temporal_rs.

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,778 46,799 +21
Ignored 1,634 1,634 0
Failed 1,842 1,821 -21
Panics 0 0 0
Conformance 93.08% 93.12% +0.04%
Fixed tests (21):
test/staging/Intl402/Temporal/old/duration-total.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/fixed-offset-near-date-time-limits.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/plain-date-time-near-limits.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/constant-offset.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/options-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/two-digit-year.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/disambiguation-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/invalid-instant.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/negative-year.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/disambiguation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainDate/limits.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/branding.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-string-datetime.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/toZonedDateTime/order-of-operations.js (previously Failed)
test/intl402/Temporal/Duration/prototype/round/dst-rounding-result.js (previously Failed)

@nekevss nekevss requested a review from a team April 30, 2025 01:10
@nekevss nekevss added the C-Builtins PRs and Issues related to builtins/intrinsics label Apr 30, 2025
@nekevss nekevss added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit 29e6fc1 Apr 30, 2025
14 checks passed
@nekevss nekevss deleted the impl-remaining-temporal-methods branch April 30, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants