Skip to content

Bump temporal_rs and add ZonedDateTime.prototype.round impl#4236

Merged
nekevss merged 1 commit intomainfrom
temporal-bump-05-06
May 7, 2025
Merged

Bump temporal_rs and add ZonedDateTime.prototype.round impl#4236
nekevss merged 1 commit intomainfrom
temporal-bump-05-06

Conversation

@nekevss
Copy link
Member

@nekevss nekevss commented May 7, 2025

This Pull Request is related to ongoing work for #1804.

Particularly exciting is that this PR removes the final "Not yet implemented" stub from Boa's side (I think temporal_rs still has 4-5 methods left, but majority have issues and/or PRs opened for them).

It changes the following:

  • Bumps temporal_rs
  • Adds ZonedDateTime.prototype.round impl
  • Changes related to updates in temporal_rs, specifically Duration's move away from f64 internally

@nekevss nekevss added the C-Builtins PRs and Issues related to builtins/intrinsics label May 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,799 46,857 +58
Ignored 1,634 1,634 0
Failed 1,821 1,763 -58
Panics 0 0 0
Conformance 93.12% 93.24% +0.12%
Fixed tests (61):
test/staging/Temporal/Duration/old/relativeto-not-required-to-round-fixed-length-units-in-durations-without-variable-units.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/options-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/overflow-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/copy-properties-not-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/offset-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/disambiguation-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/basic.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/zoned-datetime-like-at-minimum-date-time-with-offset.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/options-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/offset-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/zoned-datetime-like-at-minimum-date-time.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/overflow-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/incorrectly-spelled-properties-ignored.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/month-and-month-code-must-agree.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/overflow-reject-throws.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-halfCeil.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundto-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-expand.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/rounding-increments.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-floor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/smallestunit.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingincrement-non-integer.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/throws-without-smallestunit.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-halfTrunc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/throws-on-invalid-increments.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/smallestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/rounding-direction.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-halfFloor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-trunc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-halfEven.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/smallestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingincrement-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-halfExpand.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/throws-without-parameter.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/negative-epochnanoseconds.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/order-of-operations.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/day-rounding-out-of-range.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/rounding-is-noop.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingincrement-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-ceil.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/smallestunit-string-shorthand.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/valid-increments.js (previously Failed)
test/built-ins/Temporal/Duration/out-of-range.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/calendar-possibly-required.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-plaindate-add24hourdaystonormalizedtimeduration-out-of-range.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/no-dst-day-length.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/unit-wrong-type.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-undefined-throw-on-calendar-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/total-of-each-unit.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/argument-duration-max.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/argument-duration-max.js (previously Failed)
Broken tests (3):
test/built-ins/Temporal/Duration/prototype/subtract/argument-duration-precision-exact-numerical-values.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/out-of-range-when-converting-from-normalized-duration.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/add/argument-duration-precision-exact-numerical-values.js (previously Passed)

@nekevss
Copy link
Member Author

nekevss commented May 7, 2025

Broken tests are known about and potentially addressed in follow ups. At least one is related to floating point beyond the MAX_SAFE_INTEGER with potentially all 3 being related to that.

For more context, see the related issue

@nekevss nekevss added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit eafb437 May 7, 2025
14 checks passed
@nekevss nekevss deleted the temporal-bump-05-06 branch May 7, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants