Skip to content

Add support for LZ4 compression in embedded module loader#4261

Merged
hansl merged 2 commits intoboa-dev:mainfrom
hansl:compress-embedded-module
May 30, 2025
Merged

Add support for LZ4 compression in embedded module loader#4261
hansl merged 2 commits intoboa-dev:mainfrom
hansl:compress-embedded-module

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented May 28, 2025

This results in much smaller binaries when embedding javascript. The compression is hidden behind a flag and by default will not compress, so there is no breaking change.

This results in much smaller binaries when embedding javascript. The
compression is hidden behind a flag and by default will not compress,
so there is no breaking change.
@hansl hansl requested a review from a team May 28, 2025 21:53
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 11.84211% with 67 lines in your changes missing coverage. Please review.

Project coverage is 53.27%. Comparing base (6ddc2b4) to head (ef7f3f6).
Report is 417 commits behind head on main.

Files with missing lines Patch % Lines
core/macros/src/embedded_module_loader.rs 0.00% 62 Missing ⚠️
core/interop/src/loaders/embedded.rs 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4261      +/-   ##
==========================================
+ Coverage   47.24%   53.27%   +6.03%     
==========================================
  Files         476      487      +11     
  Lines       46892    50366    +3474     
==========================================
+ Hits        22154    26835    +4681     
+ Misses      24738    23531    -1207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat feature! Looks good to me! :D

@hansl hansl added this pull request to the merge queue May 30, 2025
Merged via the queue into boa-dev:main with commit ac9eb4b May 30, 2025
15 checks passed
@hansl hansl deleted the compress-embedded-module branch May 30, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants