Escape analyze function scopes on non-arrow functions#4266
Merged
Conversation
Test262 conformance changes
|
This was referenced Jun 3, 2025
70c6caf to
6545364
Compare
6545364 to
4b7c5cf
Compare
4b7c5cf to
eaf0b1d
Compare
Member
Author
|
This is ready for review/merge 🎉 Latest BenchmarksmainPR |
jasonwilliams
approved these changes
Jun 4, 2025
Member
jasonwilliams
left a comment
There was a problem hiding this comment.
This is even better than my suggestion which was to not GC these function environments. Instead they don't need to be created at all because if the bindings don't escape they are just poppedToLocal anyway and don't pollute the environment above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR omits functions scopes that that are not needed for non-arrow functions. We can see a nice performance increase in the QuickJS benchmarks :).