Skip to content

Fix panics on staging TypedArray.slice tests#4289

Merged
jedel1043 merged 1 commit intomainfrom
fix-staging-slice-tests
Jun 20, 2025
Merged

Fix panics on staging TypedArray.slice tests#4289
jedel1043 merged 1 commit intomainfrom
fix-staging-slice-tests

Conversation

@jedel1043
Copy link
Member

Follow up from #4288.

Fixes the two panics that occurred after bumping the Test262 commit hash.

@jedel1043 jedel1043 added this to the next-release milestone Jun 20, 2025
@jedel1043 jedel1043 requested a review from a team June 20, 2025 05:50
@jedel1043 jedel1043 added A-Bug Something isn't working A-Internal Changes that don't modify execution behaviour labels Jun 20, 2025
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,595 +341
Passed 47,132 47,246 +114
Ignored 1,444 1,714 +270
Failed 1,678 1,635 -43
Panics 0 0 0
Conformance 93.79% 93.38% -0.41%
Fixed tests (56):
test/staging/sm/TypedArray/keys.js (previously Failed)
test/staging/sm/TypedArray/from_errors.js (previously Failed)
test/staging/sm/TypedArray/set-with-receiver.js (previously Failed)
test/staging/sm/TypedArray/values.js (previously Failed)
test/staging/sm/TypedArray/from_iterable.js (previously Failed)
test/staging/sm/TypedArray/every-and-some.js (previously Failed)
test/staging/sm/TypedArray/at.js (previously Failed)
test/staging/sm/TypedArray/set-wrapped.js (previously Failed)
test/staging/sm/TypedArray/sorting_buffer_access.js (previously Failed)
test/staging/sm/TypedArray/Tconstructor-fromTypedArray-byteLength.js (previously Failed)
test/staging/sm/TypedArray/object-defineproperty.js (previously Failed)
test/staging/sm/TypedArray/from_this.js (previously Failed)
test/staging/sm/TypedArray/from_constructor.js (previously Failed)
test/staging/sm/TypedArray/sort_large_countingsort.js (previously Failed)
test/staging/sm/TypedArray/includes.js (previously Failed)
test/staging/sm/TypedArray/from_basics.js (previously Failed)
test/staging/sm/TypedArray/indexOf-and-lastIndexOf.js (previously Failed)
test/staging/sm/TypedArray/findLast-and-findLastIndex.js (previously Failed)
test/staging/sm/TypedArray/toLocaleString.js (previously Failed)
test/staging/sm/TypedArray/from_realms.js (previously Failed)
test/staging/sm/TypedArray/fill.js (previously Failed)
test/staging/sm/TypedArray/slice.js (previously Failed)
test/staging/sm/TypedArray/entries.js (previously Failed)
test/staging/sm/TypedArray/of.js (previously Failed)
test/staging/sm/TypedArray/has-property-op.js (previously Failed)
test/staging/sm/TypedArray/slice-bitwise-same.js (previously Failed)
test/staging/sm/TypedArray/join.js (previously Failed)
test/staging/sm/TypedArray/sort_byteoffset.js (previously Failed)
test/staging/sm/TypedArray/find-and-findIndex.js (previously Failed)
test/staging/sm/TypedArray/reduce-and-reduceRight.js (previously Failed)
test/staging/sm/TypedArray/from_mapping.js (previously Failed)
test/staging/sm/TypedArray/forEach.js (previously Failed)
test/staging/sm/TypedArray/element-setting-converts-using-ToNumber.js (previously Failed)
test/staging/sm/TypedArray/map-and-filter.js (previously Failed)
test/staging/sm/TypedArray/reverse.js (previously Failed)
test/staging/sm/generators/gen-with-call-obj.js (previously Failed)
test/staging/sm/statements/for-of-iterator-close.js (previously Failed)
test/staging/sm/statements/for-in-with-gc-and-unvisited-deletion.js (previously Failed)
test/staging/sm/extensions/dataview.js (previously Failed)
test/staging/sm/extensions/regress-650753.js (previously Failed)
test/staging/sm/extensions/typedarray-set-detach.js (previously Failed)
test/staging/sm/extensions/weakmap.js (previously Failed)
test/staging/sm/String/string-upper-lower-mapping.js (previously Failed)
test/staging/sm/lexical-environment/block-scoped-functions-hoisted-tdz.js (previously Failed)
test/staging/sm/lexical-environment/block-scoped-functions-deprecated-redecl.js (previously Failed)
test/staging/sm/regress/regress-592556-c35.js (previously Failed)
test/staging/sm/regress/regress-563221.js (previously Failed)
test/staging/sm/regress/regress-596103.js (previously Failed)
test/staging/sm/regress/regress-1507322-deep-weakmap.js (previously Failed)
test/staging/sm/object/clear-dictionary-accessor-getset.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/yearOfWeek/non-iso-week-of-year.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/weekOfYear/non-iso-week-of-year.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/yearOfWeek/non-iso-week-of-year.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/weekOfYear/non-iso-week-of-year.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/yearOfWeek/non-iso-week-of-year.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/weekOfYear/non-iso-week-of-year.js (previously Failed)
Broken tests (9):
test/staging/sm/RegExp/unicode-ignoreCase.js (previously Passed)
test/staging/explicit-resource-management/using-with-null-or-undefined.js (previously Passed)
test/intl402/Locale/constructor-options-throwing-getters.js (previously Passed)
test/intl402/Locale/getters-grandfathered.js (previously Passed)
test/intl402/Locale/getters-missing.js (previously Passed)
test/intl402/PluralRules/constructor-options-throwing-getters.js (previously Passed)
test/intl402/PluralRules/default-options-object-prototype.js (previously Passed)
test/intl402/PluralRules/prototype/resolvedOptions/properties.js (previously Passed)
test/intl402/PluralRules/prototype/resolvedOptions/order.js (previously Passed)

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@jedel1043 jedel1043 added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit 07e67d3 Jun 20, 2025
14 checks passed
@jedel1043 jedel1043 deleted the fix-staging-slice-tests branch June 20, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Bug Something isn't working A-Internal Changes that don't modify execution behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants