Skip to content

Replace inner Gc<T> with Rc<T> for SourceText#4293

Merged
HalidOdat merged 1 commit intomainfrom
optimization/non-gc-source-text
Jun 21, 2025
Merged

Replace inner Gc<T> with Rc<T> for SourceText#4293
HalidOdat merged 1 commit intomainfrom
optimization/non-gc-source-text

Conversation

@HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Jun 21, 2025

Small change that replaces the inner storage of SourceText, since no inner field requires tracing.

@HalidOdat HalidOdat added this to the next-release milestone Jun 21, 2025
@HalidOdat HalidOdat added A-Performance Performance related changes and issues A-Memory PRs and Issues related to the memory management or memory footprint. A-Internal Changes that don't modify execution behaviour labels Jun 21, 2025
@github-actions
Copy link

github-actions bot commented Jun 21, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,595 50,595 0
Passed 47,246 47,244 -2
Ignored 1,714 1,964 +250
Failed 1,635 1,387 -248
Panics 0 0 0
Conformance 93.38% 93.38% -0.00%
Fixed tests (12): 
test/intl402/Locale/constructor-options-variants-invalid.js (previously Failed)
test/intl402/Locale/constructor-options-throwing-getters.js (previously Failed)
test/intl402/Locale/constructor-options-variants-valid.js (previously Failed)
test/intl402/Locale/getters-grandfathered.js (previously Failed)
test/intl402/Locale/getters-missing.js (previously Failed)
test/intl402/Locale/prototype/variants/prop-desc.js (previously Failed)
test/intl402/Locale/prototype/variants/name.js (previously Failed)
test/intl402/PluralRules/notation.js (previously Failed)
test/intl402/PluralRules/constructor-options-throwing-getters.js (previously Failed)
test/intl402/PluralRules/default-options-object-prototype.js (previously Failed)
test/intl402/PluralRules/prototype/resolvedOptions/properties.js (previously Failed)
test/intl402/PluralRules/prototype/resolvedOptions/order.js (previously Failed)

@HalidOdat HalidOdat requested a review from a team June 21, 2025 17:32
jedel1043
jedel1043 approved these changes Jun 21, 2025
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@HalidOdat HalidOdat added this pull request to the merge queue Jun 21, 2025
Merged via the queue into main with commit 4c3742e Jun 21, 2025
14 checks passed
@HalidOdat HalidOdat deleted the optimization/non-gc-source-text branch June 21, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees

No one assigned

Labels

A-Internal Changes that don't modify execution behaviour A-Memory PRs and Issues related to the memory management or memory footprint. A-Performance Performance related changes and issues

Projects

None yet

Milestone

v0.21.0

Development

Successfully merging this pull request may close these issues.

2 participants

@HalidOdat @jedel1043