Move the URL class to using the boa_class macro#4294
Merged
hansl merged 1 commit intoboa-dev:mainfrom Jun 26, 2025
Merged
Conversation
Instead of the js_class one which was weird to use. This is much cleaner and takes less space. Please note we cannot move Console, since it is not a class.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4294 +/- ##
==========================================
+ Coverage 47.24% 52.40% +5.16%
==========================================
Files 476 495 +19
Lines 46892 51462 +4570
==========================================
+ Hits 22154 26971 +4817
+ Misses 24738 24491 -247 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HalidOdat
approved these changes
Jun 26, 2025
Member
HalidOdat
left a comment
There was a problem hiding this comment.
Looks good to me! Just a question :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of the js_class one which was weird to use. This is much cleaner and takes less space.
Please note we cannot move Console, since it is not a class.