Skip to content

Move the URL class to using the boa_class macro#4294

Merged
hansl merged 1 commit intoboa-dev:mainfrom
hansl:url-boa_class
Jun 26, 2025
Merged

Move the URL class to using the boa_class macro#4294
hansl merged 1 commit intoboa-dev:mainfrom
hansl:url-boa_class

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Jun 23, 2025

Instead of the js_class one which was weird to use. This is much cleaner and takes less space.

Please note we cannot move Console, since it is not a class.

Instead of the js_class one which was weird to use. This is much
cleaner and takes less space.

Please note we cannot move Console, since it is not a class.
@hansl hansl requested a review from a team June 23, 2025 04:53
@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 36 lines in your changes missing coverage. Please review.

Project coverage is 52.40%. Comparing base (6ddc2b4) to head (ea000f6).
Report is 444 commits behind head on main.

Files with missing lines Patch % Lines
core/runtime/src/url.rs 45.45% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4294      +/-   ##
==========================================
+ Coverage   47.24%   52.40%   +5.16%     
==========================================
  Files         476      495      +19     
  Lines       46892    51462    +4570     
==========================================
+ Hits        22154    26971    +4817     
+ Misses      24738    24491     -247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a question :)

@hansl hansl added this pull request to the merge queue Jun 26, 2025
Merged via the queue into boa-dev:main with commit 3700a94 Jun 26, 2025
15 checks passed
@hansl hansl deleted the url-boa_class branch June 26, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants