Conversation
jedel1043
added
A-Enhancement
Test262 conformance changes
|
nekevss
approved these changes
Jul 2, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
Super excited to see this! If-let chains are exciting. Also, super appreciated the breakdown by commit!
Looks good to me. Had one question purely about a syntax that I feel like I haven't seen before. It doesn't need to change or anything, but it was interesting to see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps our rustc version to 1.88, and bumps our edition to 2024.
Bumping the edition comes with a lot of formatting changes, but those are pretty much isolated in 0204830. The rest of the changes use the newly introduced if let chains to improve some snippets of code.