Migrate temporal_rs from 0.0.9 to 0.0.10#4318
Merged
Conversation
HalidOdat
changed the title
temporal_rs from 0.0.9 to 0.0.10
Test262 conformance changes
Broken tests (21): |
Member
|
Huh, curious what the error messages are. If there's regressions on the |
Member
Author
|
Yep, currently looking into it 😄 |
Member
Author
|
boa-dev/temporal#389 should fix the regressions 🥳 @nekevss should we merge this or wait for a temporal_rs release? |
nekevss
pushed a commit
to boa-dev/temporal
that referenced
this pull request
Jul 4, 2025
This PR fixes the regression introduced in `v0.0.10` (see boa-dev/boa#4318) by aligning the `9.5.8 AddDurationToYearMonth` abstract method to the latest specification (tc39/proposal-temporal@ed49b0b). This additionally fixes some tests that were unrelated to the regressions 🥳 : ### Test262 conformance changes | Test result | main count | PR count | difference | | :---------: | :----------: | :------: | :--------: | | Total | 50,595 | 50,595 | 0 | | Passed | 47,259 | 47,291 | **+32** | | Ignored | 1,964 | 1,964 | 0 | | Failed | 1,372 | 1,340 | **-32** | | Panics | 0 | 0 | 0 | | Conformance | 93.41% | 93.47% | **+0.06%** | <details><summary><b>Fixed tests (32):</b></summary> ``` test/built-ins/Temporal/PlainYearMonth/prototype/subtract/month-length.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/subtract/argument-lower-units.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/subtract/argument-duration-max.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/subtract/argument-string-negative-fractional-units.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/subtract/subtract-from-last-representable-month.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/subtract/end-of-month-out-of-range.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/add/month-length.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/add/argument-lower-units.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/add/argument-duration-max.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/add/argument-string-negative-fractional-units.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/add/subtract-from-last-representable-month.js (previously Failed) test/built-ins/Temporal/PlainYearMonth/prototype/add/end-of-month-out-of-range.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/calendar-always.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-string.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-string-date-with-utc-offset.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/prototype/equals/leap-second.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-string-time-zone-annotation.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-string-calendar-annotation.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-string-unknown-annotation.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-string-time-separators.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/prototype/valueOf/basic.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/prototype/with/monthdaylike-invalid.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/from/fields-string.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/from/argument-string-date-with-utc-offset.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/from/leap-second.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/from/argument-string-time-zone-annotation.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/from/argument-string-calendar-annotation.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/from/argument-string-unknown-annotation.js (previously Failed) test/built-ins/Temporal/PlainMonthDay/from/argument-string-time-separators.js (previously Failed) test/built-ins/Temporal/PlainDate/prototype/with/plaindatelike-invalid.js (previously Failed) test/built-ins/Temporal/PlainTime/prototype/with/plaintimelike-invalid.js (previously Failed) test/staging/Temporal/Regex/old/plainmonthday.js (previously Failed) ``` </details>
nekevss
approved these changes
Jul 4, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
I'm fine with merging as is.
The only regression I'm slightly concerned about currently is the order-of-operations.js, but we can always look into that after the next release once the merged fix is available.
We're on a much more regular release schedule too since now with the V8 work, so it really shouldn't be too long before its fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates
temporal_rsto the recent0.0.10version.