Skip to content

Mark the error path in Call::operation as cold.#4319

Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom
cijiugechu:call-operation-cold-path
Jul 4, 2025
Merged

Mark the error path in Call::operation as cold.#4319
jedel1043 merged 1 commit intoboa-dev:mainfrom
cijiugechu:call-operation-cold-path

Conversation

@cijiugechu
Copy link
Contributor

It will bring a slight performance improvement.

Benchmark

main:

PROGRESS Richards
RESULT Richards 105
PROGRESS DeltaBlue
RESULT DeltaBlue 108
PROGRESS Encrypt
PROGRESS Decrypt
RESULT Crypto 118
PROGRESS RayTrace
RESULT RayTrace 255
PROGRESS Earley
PROGRESS Boyer
RESULT EarleyBoyer 297
PROGRESS RegExp
RESULT RegExp 59.5
PROGRESS Splay
RESULT Splay 420
PROGRESS NavierStokes
RESULT NavierStokes 268
SCORE 169
undefined

PR:

PROGRESS Richards
RESULT Richards 109
PROGRESS DeltaBlue
RESULT DeltaBlue 114
PROGRESS Encrypt
PROGRESS Decrypt
RESULT Crypto 119
PROGRESS RayTrace
RESULT RayTrace 262
PROGRESS Earley
PROGRESS Boyer
RESULT EarleyBoyer 299
PROGRESS RegExp
RESULT RegExp 59.6
PROGRESS Splay
RESULT Splay 450
PROGRESS NavierStokes
RESULT NavierStokes 277
SCORE 175
undefined

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.27%. Comparing base (6ddc2b4) to head (dfa7710).
Report is 455 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4319      +/-   ##
==========================================
+ Coverage   47.24%   50.27%   +3.02%     
==========================================
  Files         476      495      +19     
  Lines       46892    49591    +2699     
==========================================
+ Hits        22154    24931    +2777     
+ Misses      24738    24660      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@jedel1043 jedel1043 added A-Performance Performance related changes and issues A-Internal Changes that don't modify execution behaviour labels Jul 4, 2025
@jedel1043 jedel1043 added this pull request to the merge queue Jul 4, 2025
Merged via the queue into boa-dev:main with commit 81d240b Jul 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Internal Changes that don't modify execution behaviour A-Performance Performance related changes and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants