Make JobExecutor::run_jobs_async a plain async method#4331
Merged
Conversation
jedel1043
added
A-Enhancement
Test262 conformance changes
|
hansl
approved these changes
Jul 11, 2025
Contributor
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
Some optional simplification of the code, otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
JobExecutor::run_jobs_asynca proper async function, which greatly simplifies our API by removing all the ugly lifetimes.The change that enabled this was to make the trait's receiver a
Rc<Self>, which can be moved inside the future returned by the function.In contrast to #4328, we don't really require async trait objects in this case, since the only thing that the engine does is calling
enqueue_jobandrun_jobs, which are plain old methods. Thus, I excluded therun_jobs_asyncmethod from the trait's VTable with awhere Self: Sizedbound, but the method can still be called by creating theRc<Queue>executor first, then passing a clone to theContextBuilder.