Skip to content

Avoid fully awaiting futures in async event loops #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jedel1043 merged 1 commit into from
Jul 12, 2025
Merged

Avoid fully awaiting futures in async event loops #4332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions examples/src/bin/module_fetch_async.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,16 +220,9 @@ impl JobExecutor for Queue {
group.insert(job.call(context));
}

if self.promise_jobs.borrow().is_empty() {
let Some(result) = group.next().await else {
// Both queues are empty. We can exit.
return Ok(());
};

if let Err(err) = result {
eprintln!("Uncaught {err}");
}
continue;
if group.is_empty() && self.promise_jobs.borrow().is_empty() {
// Both queues are empty. We can exit.
return Ok(());
}

// We have some jobs pending on the microtask queue. Try to poll the pending
Expand Down
13 changes: 3 additions & 10 deletions examples/src/bin/smol_event_loop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,9 @@ impl JobExecutor for Queue {
group.insert(job.call(context));
}

if self.promise_jobs.borrow().is_empty() {
let Some(result) = group.next().await else {
// Both queues are empty. We can exit.
return Ok(());
};

if let Err(err) = result {
eprintln!("Uncaught {err}");
}
continue;
if group.is_empty() && self.promise_jobs.borrow().is_empty() {
// Both queues are empty. We can exit.
return Ok(());
}

// We could have some jobs pending on the microtask queue. Try to poll the pending
Expand Down
14 changes: 3 additions & 11 deletions examples/src/bin/tokio_event_loop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,17 +116,9 @@ impl JobExecutor for Queue {
group.insert(job.call(context));
}

if self.promise_jobs.borrow().is_empty() {
let Some(result) = group.next().await else {
// Both queues are empty. We can exit.
return Ok(());
};

if let Err(err) = result {
eprintln!("Uncaught {err}");
}

continue;
if group.is_empty() && self.promise_jobs.borrow().is_empty() {
// Both queues are empty. We can exit.
return Ok(());
}

// We have some jobs pending on the microtask queue. Try to poll the pending
Expand Down
Loading