Skip to content

Use AsyncFnOnce in constructors of NativeAsyncJob#4333

Merged
jedel1043 merged 1 commit intomainfrom
new-native-async-job
Jul 13, 2025
Merged

Use AsyncFnOnce in constructors of NativeAsyncJob#4333
jedel1043 merged 1 commit intomainfrom
new-native-async-job

Conversation

@jedel1043
Copy link
Member

Changes the signature of the constructors of NativeAsyncJob, avoiding having to manually Box::pin the provided closure.

@jedel1043 jedel1043 added this to the next-release milestone Jul 12, 2025
@jedel1043 jedel1043 requested a review from a team July 12, 2025 04:50
@jedel1043 jedel1043 added A-Enhancement New feature or request A-API Changes related to public APIs labels Jul 12, 2025
@jedel1043 jedel1043 marked this pull request as draft July 12, 2025 04:55
@jedel1043 jedel1043 force-pushed the async-module-loaders branch from 79394fc to df27300 Compare July 12, 2025 17:13
Base automatically changed from async-module-loaders to main July 12, 2025 17:35
@jedel1043 jedel1043 force-pushed the new-native-async-job branch from 83d53d0 to ac58855 Compare July 13, 2025 13:47
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,595 50,595 0
Passed 47,110 47,110 0
Ignored 2,192 2,192 0
Failed 1,293 1,293 0
Panics 0 0 0
Conformance 93.11% 93.11% 0.00%

@jedel1043 jedel1043 marked this pull request as ready for review July 13, 2025 13:57
@jedel1043 jedel1043 added this pull request to the merge queue Jul 13, 2025
Merged via the queue into main with commit 26c8fce Jul 13, 2025
15 checks passed
@jedel1043 jedel1043 deleted the new-native-async-job branch July 13, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-API Changes related to public APIs A-Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants