Skip to content

Allow public access to the full position of a call frame#4365

Merged
hansl merged 6 commits intoboa-dev:mainfrom
hansl:better_source_info
Aug 8, 2025
Merged

Allow public access to the full position of a call frame#4365
hansl merged 6 commits intoboa-dev:mainfrom
hansl:better_source_info

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Aug 6, 2025

Prior to this, it was impossible for an application to know the origin of an API call.

My use case is that I want to enable back trace logging on console.trace() or when a CLI flag is used.

Prior to this, it was impossible for an application to know the
origin of an API call.
@hansl hansl requested a review from a team August 6, 2025 04:08
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.26%. Comparing base (6ddc2b4) to head (ec3c612).
⚠️ Report is 494 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/vm/code_block.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4365      +/-   ##
==========================================
+ Coverage   47.24%   50.26%   +3.02%     
==========================================
  Files         476      507      +31     
  Lines       46892    50846    +3954     
==========================================
+ Hits        22154    25560    +3406     
- Misses      24738    25286     +548     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment this looks good to me :)

@hansl hansl enabled auto-merge August 8, 2025 20:07
@hansl hansl added this pull request to the merge queue Aug 8, 2025
Merged via the queue into boa-dev:main with commit c486dff Aug 8, 2025
16 checks passed
@hansl hansl deleted the better_source_info branch August 8, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants