Skip to content

Remove the boa_interop module#4407

Merged
hansl merged 7 commits intoboa-dev:mainfrom
hansl:remove_interop
Sep 8, 2025
Merged

Remove the boa_interop module#4407
hansl merged 7 commits intoboa-dev:mainfrom
hansl:remove_interop

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Sep 4, 2025

Move the useful loaders into boa_engine, and the tests into boa_macros_tests.

Closes #3905

Move the useful loaders into boa_engine, and the tests into boa_macros_tests.
@hansl hansl requested a review from a team September 4, 2025 17:12
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.83%. Comparing base (6ddc2b4) to head (5385a21).
⚠️ Report is 519 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/module/loader/mod.rs 73.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4407      +/-   ##
==========================================
+ Coverage   47.24%   50.83%   +3.58%     
==========================================
  Files         476      501      +25     
  Lines       46892    51192    +4300     
==========================================
+ Hits        22154    26023    +3869     
- Misses      24738    25169     +431     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nekevss
Copy link
Member

nekevss commented Sep 5, 2025

We will need to remember to update boa_interop as deprecated in our documentation.

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Note: this should close #3905

Also, I'm slightly curious if it's worth having a "crate graveyard" for deprecated crates that is outside of core.

@hansl hansl added this pull request to the merge queue Sep 8, 2025
@hansl
Copy link
Contributor Author

hansl commented Sep 8, 2025

@nekevss Once the release is done, I'll actually remove this crate from our repo. I don't know about a graveyard.

Merged via the queue into boa-dev:main with commit 90ca12f Sep 8, 2025
16 checks passed
@hansl hansl deleted the remove_interop branch September 8, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge boa_interop into other crates

2 participants