Merged
Conversation
- Empty enums are uninhabited types and referencing them is UB. - Removed the ref in `GcRefMut<>` and `GcRef<>` in favor of `NonNull<>` for good hygiene. - Simplified the type of `GcRefMut` by having a ref to the flags instead of keeping a ref to the `GcRefCell` itself. - Unconstrained the types for `Deref` and `DerefMut` for `Ref`/`RefMut`.
970281a to
1fe3793
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4422 +/- ##
==========================================
+ Coverage 47.24% 51.27% +4.02%
==========================================
Files 476 502 +26
Lines 46892 51291 +4399
==========================================
+ Hits 22154 26297 +4143
- Misses 24738 24994 +256 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GcRefCell
nekevss
reviewed
Sep 18, 2025
Member
nekevss
left a comment
There was a problem hiding this comment.
Looks great! Had a couple nits and a question to start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GcRefMut<>andGcRef<>in favor ofNonNull<>for good hygiene.GcRefMutby having a ref to the flags instead of keeping a ref to theGcRefCellitself.DerefandDerefMutforRef/RefMut.assert_neinstead ofassert!(... != ...), or typos in comments, etc.