Skip to content

Add a simple cargo-make to the project#4437

Merged
hansl merged 2 commits intoboa-dev:mainfrom
hansl:cargo-make
Sep 26, 2025
Merged

Add a simple cargo-make to the project#4437
hansl merged 2 commits intoboa-dev:mainfrom
hansl:cargo-make

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Sep 25, 2025

It makes it easier to run test262 and JS benchmarks.

@hansl hansl requested a review from a team September 25, 2025 18:41
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.37%. Comparing base (6ddc2b4) to head (6d323dc).
⚠️ Report is 538 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4437      +/-   ##
==========================================
+ Coverage   47.24%   51.37%   +4.13%     
==========================================
  Files         476      504      +28     
  Lines       46892    51361    +4469     
==========================================
+ Hits        22154    26389    +4235     
- Misses      24738    24972     +234     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for adding cargo make. I can't remember if I've brought it up on matrix, but I've wanted to add it for a little while now. It would allow us to add some tools that would help with managing the project and streamline the general workflow.

args = ["test", "${@}"]
workspace = false

[tasks.test262]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I'm not entirely sure that we should have one test262 command that's set to release.

Overflows will only panic in debug, so running the test suite only ever with the --release flag could hide some easy to catch bugs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have both with debug being the default? Some issues might arise in release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's fine. Assuming that they are two separate tasks. I'm not entirely sure everyone needs to be running them back-to-back in one task though. That would be like 10+ minutes of tests.

My biggest concern is that if we add a task that only ever uses release and we get comfortable just using that task, then we might end up missing something that starts panicking in debug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added environment profiles, which makes it easier. This whole thing could be better but likely will improve over time :)

CleanShot 2025-09-26 at 09 50 27@2x

@nekevss nekevss requested a review from a team September 25, 2025 20:51
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding that!

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! 😄

@hansl hansl added this pull request to the merge queue Sep 26, 2025
Merged via the queue into boa-dev:main with commit bb47b07 Sep 26, 2025
16 checks passed
@hansl hansl deleted the cargo-make branch September 26, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants