Add a simple cargo-make to the project#4437
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4437 +/- ##
==========================================
+ Coverage 47.24% 51.37% +4.13%
==========================================
Files 476 504 +28
Lines 46892 51361 +4469
==========================================
+ Hits 22154 26389 +4235
- Misses 24738 24972 +234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nekevss
left a comment
There was a problem hiding this comment.
I'm for adding cargo make. I can't remember if I've brought it up on matrix, but I've wanted to add it for a little while now. It would allow us to add some tools that would help with managing the project and streamline the general workflow.
| args = ["test", "${@}"] | ||
| workspace = false | ||
|
|
||
| [tasks.test262] |
There was a problem hiding this comment.
thought: I'm not entirely sure that we should have one test262 command that's set to release.
Overflows will only panic in debug, so running the test suite only ever with the --release flag could hide some easy to catch bugs.
There was a problem hiding this comment.
Should we have both with debug being the default? Some issues might arise in release.
There was a problem hiding this comment.
Yeah, that's fine. Assuming that they are two separate tasks. I'm not entirely sure everyone needs to be running them back-to-back in one task though. That would be like 10+ minutes of tests.
My biggest concern is that if we add a task that only ever uses release and we get comfortable just using that task, then we might end up missing something that starts panicking in debug.

It makes it easier to run
test262and JS benchmarks.