Editorconfig: specify indentation and dont overrule Makefile#4446
Merged
hansl merged 2 commits intoboa-dev:mainfrom Sep 26, 2025
Merged
Editorconfig: specify indentation and dont overrule Makefile#4446hansl merged 2 commits intoboa-dev:mainfrom
hansl merged 2 commits intoboa-dev:mainfrom
Conversation
nekevss
approved these changes
Sep 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4446 +/- ##
==========================================
+ Coverage 47.24% 51.37% +4.13%
==========================================
Files 476 504 +28
Lines 46892 51361 +4469
==========================================
+ Hits 22154 26389 +4235
- Misses 24738 24972 +234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the Makefile rule was overridden as rules are evaluated in order and merged in order. Also, if your editor is set to a different tab size/style, it wasn't correct for this project.
This will avoid changes like these in PRs: https://github.com/boa-dev/boa/pull/4436/files#diff-5f57f7d9e7e1a6c330e90b09112acd05a90d11afde996c58dd056f69e30fc4c1