Skip to content

Editorconfig: specify indentation and dont overrule Makefile#4446

Merged
hansl merged 2 commits intoboa-dev:mainfrom
hansl:improve-editorconfig
Sep 26, 2025
Merged

Editorconfig: specify indentation and dont overrule Makefile#4446
hansl merged 2 commits intoboa-dev:mainfrom
hansl:improve-editorconfig

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Sep 26, 2025

Before, the Makefile rule was overridden as rules are evaluated in order and merged in order. Also, if your editor is set to a different tab size/style, it wasn't correct for this project.

This will avoid changes like these in PRs: https://github.com/boa-dev/boa/pull/4436/files#diff-5f57f7d9e7e1a6c330e90b09112acd05a90d11afde996c58dd056f69e30fc4c1

@hansl hansl requested a review from a team September 26, 2025 16:27
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.37%. Comparing base (6ddc2b4) to head (168bff5).
⚠️ Report is 537 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4446      +/-   ##
==========================================
+ Coverage   47.24%   51.37%   +4.13%     
==========================================
  Files         476      504      +28     
  Lines       46892    51361    +4469     
==========================================
+ Hits        22154    26389    +4235     
- Misses      24738    24972     +234     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hansl hansl enabled auto-merge September 26, 2025 16:40
@hansl hansl added this pull request to the merge queue Sep 26, 2025
Merged via the queue into boa-dev:main with commit 833b241 Sep 26, 2025
16 checks passed
@hansl hansl deleted the improve-editorconfig branch September 26, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants