Replace manual Default impls with #[derive(Default)]#4517
Merged
HalidOdat merged 2 commits intoboa-dev:mainfrom Nov 17, 2025
Merged
Replace manual Default impls with #[derive(Default)]#4517HalidOdat merged 2 commits intoboa-dev:mainfrom
Default impls with #[derive(Default)]#4517HalidOdat merged 2 commits intoboa-dev:mainfrom
Conversation
Member
|
This was already fixed by #4513 |
Test262 conformance changes
|
Contributor
Author
|
I’ve rebased on top of main, there are still changes worth it in this PR, since I’m running clippy nightly locally. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4517 +/- ##
==========================================
+ Coverage 47.24% 56.96% +9.72%
==========================================
Files 476 503 +27
Lines 46892 57506 +10614
==========================================
+ Hits 22154 32759 +10605
- Misses 24738 24747 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HalidOdat
reviewed
Nov 17, 2025
Member
There was a problem hiding this comment.
Besides the comment below, this looks good to me! @linkmauve
😄
Thanks to the #[default] tag we can avoid a bunch of such manual derives on enums.
linkmauve
force-pushed
the
fix-clippy
branch
from
2ad7da8 to
d1ab738
Compare
Thanks clippy!
linkmauve
force-pushed
the
fix-clippy
branch
from
d1ab738 to
e78d0dc
Compare
HalidOdat
changed the title
Default impls with #[derive(Default)]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes no issue.
It changes the following:
.to_string().impl Defaults with#[derive(Default)]Durationsubtraction.