fix: implement TryIntoJs and TryFromJs for common Rust wrapper types#4727
fix: implement TryIntoJs and TryFromJs for common Rust wrapper types#4727jakharmonika364 wants to merge 3 commits intoboa-dev:mainfrom
Conversation
e1b538a to
becb9be
Compare
Test262 conformance changes
Tested main commit: |
|
Just want to clarify, this PR does not change the TryIntoJs macro, what am I missing? |
|
I noticed after pushing that the prototype fix in the macro was already there in main. The main point of this PR now is implementing TryIntoJs and TryFromJs from wrapper types. I had to refactor how native classes handle conversion to resolve a trait conflict that was previously blocking those wrapper implementations. I'll update the PR description to reflect the actual changes. |
becb9be to
2fd34c9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4727 +/- ##
===========================================
+ Coverage 47.24% 59.37% +12.13%
===========================================
Files 476 580 +104
Lines 46892 63161 +16269
===========================================
+ Hits 22154 37504 +15350
- Misses 24738 25657 +919 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Needs a |
Head branch was pushed to by a user without write access
b6a4632 to
29287f7
Compare
29287f7 to
f131f6e
Compare
Fixed the cargo clippy warning by replacing str::replace with cow_utils::CowUtils::cow_replace to avoid unnecessary heap allocation when the specifier doesn't contain /. |
Use `&*specifier` to deref Cow<str> for Path::new and join calls, and use the full path `cow_utils::CowUtils::cow_replace` without import.
13271f3 to
4721a96
Compare
Closes #4360
This PR implements TryIntoJs and TryFromJs for common Rust wrapper types and refactors class conversions to resolve trait conflicts.
Key Changes: