feat(builtins): implement JsGeneratorFunction safe wrapper#4756
Merged
jedel1043 merged 3 commits intoboa-dev:mainfrom Feb 28, 2026
Merged
feat(builtins): implement JsGeneratorFunction safe wrapper#4756jedel1043 merged 3 commits intoboa-dev:mainfrom
jedel1043 merged 3 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4756 +/- ##
==========================================
+ Coverage 47.24% 57.01% +9.77%
==========================================
Files 476 553 +77
Lines 46892 60593 +13701
==========================================
+ Hits 22154 34547 +12393
- Misses 24738 26046 +1308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
requested changes
Feb 28, 2026
Contributor
Author
|
Hi @jedel1043, thank you for the quick review and guidance throughout these PRs — your feedback has been very clear and helpful. Really appreciate your support! thanks again ( whenever u get chance take a look at #4755 the only wrapper that is remaining in our original #2098 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
JsGeneratorFunctionsafe Rust wrapper as part of #2098.Adds
core/engine/src/object/builtins/jsgeneratorfunction.rswith:from_object(object: JsObject) -> JsResult<Self>call(this, args, context) -> JsResult<JsValue>From<JsGeneratorFunction>forJsObjectandJsValueDereftoJsObjectTryFromJsimplGeneratorFunctionhas noJsDataderive, so type detection usesdowncast_ref::<OrdinaryFunction>()and checkscode.is_generator() && !code.is_async().