Use Personal Access Token for pushing to the data repo#4795
Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom Mar 2, 2026
Merged
Use Personal Access Token for pushing to the data repo#4795jedel1043 merged 1 commit intoboa-dev:mainfrom
jedel1043 merged 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested PR commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4795 +/- ##
===========================================
+ Coverage 47.24% 57.36% +10.11%
===========================================
Files 476 554 +78
Lines 46892 60713 +13821
===========================================
+ Hits 22154 34825 +12671
- Misses 24738 25888 +1150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
How do we ensure the PAT will be kept secure? |
Member
Author
|
By using secrets apparently. The alternative was to use an app, but it seemed iffy to have an app for just pushing a single commit. The secret is scoped to only being able to access the data repo, and it expires in a year for good measure. Aside from that we can't do much else |
hansl
approved these changes
Mar 2, 2026
ashddev
pushed a commit
to ashddev/boa
that referenced
this pull request
Mar 2, 2026
The default github token cannot write to other repositories, so this uses a separate PAT with write permissions to `boa-dev/data`.
jedel1043
added a commit
that referenced
this pull request
Mar 29, 2026
The default github token cannot write to other repositories, so this uses a separate PAT with write permissions to `boa-dev/data`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default github token cannot write to other repositories, so this uses a separate PAT with write permissions to
boa-dev/data.