Skip to content

Use Personal Access Token for pushing to the data repo#4795

Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom
jedel1043:use-pat-for-test262
Mar 2, 2026
Merged

Use Personal Access Token for pushing to the data repo#4795
jedel1043 merged 1 commit intoboa-dev:mainfrom
jedel1043:use-pat-for-test262

Conversation

@jedel1043
Copy link
Copy Markdown
Member

The default github token cannot write to other repositories, so this uses a separate PAT with write permissions to boa-dev/data.

@jedel1043 jedel1043 added the A-Bug Something isn't working label Mar 2, 2026
@jedel1043 jedel1043 requested a review from a team as a code owner March 2, 2026 03:39
@jedel1043 jedel1043 added the A-Meta Issues and PRs related to the repository itself label Mar 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,862 52,862 0
Passed 49,506 49,506 0
Ignored 2,261 2,261 0
Failed 1,095 1,095 0
Panics 0 0 0
Conformance 93.65% 93.65% 0.00%

Tested PR commit: 4e65103c411ea78a9878116bf8eb28ebaca78fd9

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.36%. Comparing base (6ddc2b4) to head (4e65103).
⚠️ Report is 720 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4795       +/-   ##
===========================================
+ Coverage   47.24%   57.36%   +10.11%     
===========================================
  Files         476      554       +78     
  Lines       46892    60713    +13821     
===========================================
+ Hits        22154    34825    +12671     
- Misses      24738    25888     +1150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hansl
Copy link
Copy Markdown
Contributor

hansl commented Mar 2, 2026

How do we ensure the PAT will be kept secure?

@jedel1043
Copy link
Copy Markdown
Member Author

jedel1043 commented Mar 2, 2026

By using secrets apparently. The alternative was to use an app, but it seemed iffy to have an app for just pushing a single commit.

The secret is scoped to only being able to access the data repo, and it expires in a year for good measure. Aside from that we can't do much else

@jedel1043 jedel1043 added this pull request to the merge queue Mar 2, 2026
Merged via the queue into boa-dev:main with commit 8937644 Mar 2, 2026
19 checks passed
@jedel1043 jedel1043 deleted the use-pat-for-test262 branch March 2, 2026 06:10
ashddev pushed a commit to ashddev/boa that referenced this pull request Mar 2, 2026
The default github token cannot write to other repositories, so this
uses a separate PAT with write permissions to `boa-dev/data`.
jedel1043 added a commit that referenced this pull request Mar 29, 2026
The default github token cannot write to other repositories, so this
uses a separate PAT with write permissions to `boa-dev/data`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Bug Something isn't working A-Meta Issues and PRs related to the repository itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants