Skip to content

fix(ci): ensure codecov runs for internal PRs targeting main#4800

Closed
JkrishnaD wants to merge 1 commit intoboa-dev:mainfrom
JkrishnaD:fix/codecov
Closed

fix(ci): ensure codecov runs for internal PRs targeting main#4800
JkrishnaD wants to merge 1 commit intoboa-dev:mainfrom
JkrishnaD:fix/codecov

Conversation

@JkrishnaD
Copy link
Contributor

This Pull Request fixes/closes #4179.

It changes the following:

  • The coverage job was not running for pull requests created from branches within the same repository due to the previous condition:
if: ${{ github.ref == 'refs/heads/main' || github.base_ref == 'main' }}
  • So, now to ensure that this to work for every pr we need to change this to
 if: ${{ github.ref == 'refs/heads/main' || github.event_name = 'pull_request' }}
  • This updates the condition to ensure the coverage job runs for all pull_request events as well as pushes to main, so Codecov comments are posted consistently for both internal and fork PRs.

@JkrishnaD JkrishnaD requested a review from a team as a code owner March 2, 2026 07:44
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,862 52,862 0
Passed 49,506 49,506 0
Ignored 2,261 2,261 0
Failed 1,095 1,095 0
Panics 0 0 0
Conformance 93.65% 93.65% 0.00%

Tested PR commit: b5a97fd31b2cd9e929a631a326a25abae5be340b

@zhuzhu81998
Copy link
Contributor

zhuzhu81998 commented Mar 2, 2026

not sure if this actually fixes the issue. it is not that the coverage workflow does not run for internal PRs. according to #4178, it does run, it simply does not comment.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.35%. Comparing base (6ddc2b4) to head (b5a97fd).
⚠️ Report is 723 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4800       +/-   ##
===========================================
+ Coverage   47.24%   57.35%   +10.11%     
===========================================
  Files         476      554       +78     
  Lines       46892    60715    +13823     
===========================================
+ Hits        22154    34825    +12671     
- Misses      24738    25890     +1152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JkrishnaD
Copy link
Contributor Author

@zhuzhu81998 Thanks for pointing this out.

After investigating further, it looks like the original PR-comment issue is working fine. The remaining failure I observed is related to uploads on protected branches (main), which requires a CODECOV_TOKEN and is separate from the PR comment behavior.

Since this PR no longer addresses the root issue, I’m closing it and we can continue the discussion in the issue thread if needed.

@JkrishnaD JkrishnaD closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage bot does not work for repo branches

2 participants