fix(ci): ensure codecov runs for internal PRs targeting main#4800
fix(ci): ensure codecov runs for internal PRs targeting main#4800JkrishnaD wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested PR commit: |
|
not sure if this actually fixes the issue. it is not that the coverage workflow does not run for internal PRs. according to #4178, it does run, it simply does not comment. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4800 +/- ##
===========================================
+ Coverage 47.24% 57.35% +10.11%
===========================================
Files 476 554 +78
Lines 46892 60715 +13823
===========================================
+ Hits 22154 34825 +12671
- Misses 24738 25890 +1152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@zhuzhu81998 Thanks for pointing this out. After investigating further, it looks like the original PR-comment issue is working fine. The remaining failure I observed is related to uploads on protected branches ( Since this PR no longer addresses the root issue, I’m closing it and we can continue the discussion in the issue thread if needed. |
This Pull Request fixes/closes #4179.
It changes the following:
pull_requestevents as well as pushes to main, so Codecov comments are posted consistently for both internal and fork PRs.