fix(jsarray): convert panics to EngineError::Panic using js_expect#4837
Merged
jedel1043 merged 3 commits intoboa-dev:mainfrom Mar 3, 2026
Merged
fix(jsarray): convert panics to EngineError::Panic using js_expect#4837jedel1043 merged 3 commits intoboa-dev:mainfrom
jedel1043 merged 3 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested PR commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4837 +/- ##
===========================================
+ Coverage 47.24% 57.32% +10.08%
===========================================
Files 476 554 +78
Lines 46892 60581 +13689
===========================================
+ Hits 22154 34730 +12576
- Misses 24738 25851 +1113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 3, 2026
jedel1043
added
A-Technical Debt
Contributor
Author
|
@jedel1043 thanks |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
…ct (#4844) Part of #3241 Converts all 26 panics in `jstypedarray.rs` to `EngineError::Panic` using the `js_expect` ergonomics introduced in #4828. Unlike #4837 which touched 8 files due to a public API change, this PR only modifies 1 file since no public API signatures were changed all methods already returned `JsResult<T>`, only the internal implementations were updated. Patterns converted: - `.as_number().map(...).expect()` → `.js_expect()?` - `.as_object().expect()` → `.as_object().js_expect()?` - `.as_boolean().expect()` → `.as_boolean().js_expect()?` - `.map(|x| x.as_string().expect())` → `.and_then(|x| x.as_string().js_expect().map_err(Into::into))` - 3 macro panics inside `JsTypedArrayType!` (`from_array_buffer`, `from_shared_array_buffer`, `from_iter`) The 4 remaining `.expect(` in the file are inside `///` doc comment examples, not real code.
hansl
pushed a commit
to hansl/boa
that referenced
this pull request
Mar 3, 2026
…ct (boa-dev#4844) Part of boa-dev#3241 Converts all 26 panics in `jstypedarray.rs` to `EngineError::Panic` using the `js_expect` ergonomics introduced in boa-dev#4828. Unlike boa-dev#4837 which touched 8 files due to a public API change, this PR only modifies 1 file since no public API signatures were changed all methods already returned `JsResult<T>`, only the internal implementations were updated. Patterns converted: - `.as_number().map(...).expect()` → `.js_expect()?` - `.as_object().expect()` → `.as_object().js_expect()?` - `.as_boolean().expect()` → `.as_boolean().js_expect()?` - `.map(|x| x.as_string().expect())` → `.and_then(|x| x.as_string().js_expect().map_err(Into::into))` - 3 macro panics inside `JsTypedArrayType!` (`from_array_buffer`, `from_shared_array_buffer`, `from_iter`) The 4 remaining `.expect(` in the file are inside `///` doc comment examples, not real code.
ashddev
pushed a commit
to ashddev/boa
that referenced
this pull request
Mar 4, 2026
…oa-dev#4837) Part of boa-dev#3241 Converts all 14 panics in `jsarray.rs` to use `js_expect` introduced in boa-dev#4828, replacing `.expect()` calls that would crash the process with recoverable `EngineError::Panic` errors that bubble up to the host application. Changes: - `JsArray::new` now returns `JsResult<Self>` instead of `Self` - All 14 `.expect()` calls replaced with `.js_expect()?` - Updated all callers of `JsArray::new` across the codebase - Fixed doc examples in `jsmap.rs` and `jsobject.rs`
ashddev
pushed a commit
to ashddev/boa
that referenced
this pull request
Mar 4, 2026
…ct (boa-dev#4844) Part of boa-dev#3241 Converts all 26 panics in `jstypedarray.rs` to `EngineError::Panic` using the `js_expect` ergonomics introduced in boa-dev#4828. Unlike boa-dev#4837 which touched 8 files due to a public API change, this PR only modifies 1 file since no public API signatures were changed all methods already returned `JsResult<T>`, only the internal implementations were updated. Patterns converted: - `.as_number().map(...).expect()` → `.js_expect()?` - `.as_object().expect()` → `.as_object().js_expect()?` - `.as_boolean().expect()` → `.as_boolean().js_expect()?` - `.map(|x| x.as_string().expect())` → `.and_then(|x| x.as_string().js_expect().map_err(Into::into))` - 3 macro panics inside `JsTypedArrayType!` (`from_array_buffer`, `from_shared_array_buffer`, `from_iter`) The 4 remaining `.expect(` in the file are inside `///` doc comment examples, not real code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3241
Converts all 14 panics in
jsarray.rsto usejs_expectintroduced in #4828, replacing.expect()calls that would crash the process with recoverableEngineError::Panicerrors that bubble up to the host application.Changes:
JsArray::newnow returnsJsResult<Self>instead ofSelf.expect()calls replaced with.js_expect()?JsArray::newacross the codebasejsmap.rsandjsobject.rs