fix(jsdataview): convert panics to EngineError::Panic using js_expect#4842
Merged
nekevss merged 1 commit intoboa-dev:mainfrom Mar 4, 2026
Merged
Conversation
Test262 conformance changes
Tested PR commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4842 +/- ##
===========================================
+ Coverage 47.24% 57.32% +10.08%
===========================================
Files 476 554 +78
Lines 46892 60611 +13719
===========================================
+ Hits 22154 34746 +12592
- Misses 24738 25865 +1127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
hey @jedel1043 is that internal server error is because of github or any mistake fromm my side
|
Member
|
GitHub has been having some service issues. 500 points to GitHub |
KaustubhOG
force-pushed
the
fix/convert-panics-jsdataview
branch
from
0b762c7 to
e74e04b
Compare
nekevss
approved these changes
Mar 4, 2026
jedel1043
added
A-Enhancement
ashddev
pushed a commit
to ashddev/boa
that referenced
this pull request
Mar 4, 2026
…boa-dev#4842) Part of boa-dev#3241 Converts all 12 panics in `jsdataview.rs` to use `js_expect` introduced in boa-dev#4828, replacing `.expect()` calls that would crash the process with recoverable `EngineError::Panic` errors that bubble up to the host application. No public API changes — all methods already returned `JsResult<T>`, only the internal implementation was updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3241
Converts all 12 panics in
jsdataview.rsto usejs_expectintroducedin #4828, replacing
.expect()calls that would crash the process withrecoverable
EngineError::Panicerrors that bubble up to the hostapplication.
No public API changes — all methods already returned
JsResult<T>,only the internal implementation was updated.