fix(jsregexp): convert panics to EngineError::Panic using js_expect#4846
Merged
nekevss merged 1 commit intoboa-dev:mainfrom Mar 5, 2026
Merged
fix(jsregexp): convert panics to EngineError::Panic using js_expect#4846nekevss merged 1 commit intoboa-dev:mainfrom
nekevss merged 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested PR commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4846 +/- ##
==========================================
+ Coverage 47.24% 57.13% +9.89%
==========================================
Files 476 554 +78
Lines 46892 60484 +13592
==========================================
+ Hits 22154 34558 +12404
- Misses 24738 25926 +1188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
reviewed
Mar 4, 2026
nekevss
requested changes
Mar 4, 2026
0224072 to
209b22b
Compare
nekevss
reviewed
Mar 4, 2026
209b22b to
a4ea5e7
Compare
nekevss
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3241
Converts all 17 panics in
jsregexp.rstoEngineError::Panicusingjs_expectintroduced in #4828.No public API signatures were changed — only 1 file modified.
Patterns converted:
.as_object().expect()→.as_object().js_expect()?.map(|v| v.as_boolean().expect())→.and_then(|v| v.as_boolean().js_expect().map_err(Into::into)).map(|v| v.as_string().expect()...to_std_string().expect())→.and_then(|v| v.as_string().js_expect()?.to_std_string().map_err(...)).expect()calls inexec()converted using?inside.and_then()