fix(jsproxy): convert panics to EngineError::Panic using js_expect#4854
Merged
nekevss merged 3 commits intoboa-dev:mainfrom Mar 4, 2026
Merged
fix(jsproxy): convert panics to EngineError::Panic using js_expect#4854nekevss merged 3 commits intoboa-dev:mainfrom
nekevss merged 3 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested PR commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4854 +/- ##
==========================================
+ Coverage 47.24% 57.13% +9.89%
==========================================
Files 476 554 +78
Lines 46892 60467 +13575
==========================================
+ Hits 22154 34550 +12396
- Misses 24738 25917 +1179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nekevss
approved these changes
Mar 4, 2026
ashddev
pushed a commit
to ashddev/boa
that referenced
this pull request
Mar 4, 2026
…oa-dev#4854) Part of boa-dev#3241 Converts all 13 panics in `jsproxy.rs` to `EngineError::Panic` using `js_expect` introduced in boa-dev#4828. `build()` and `build_revocable()` return types changed from `JsProxy`/ `JsRevocableProxy` to `JsResult<JsProxy>`/`JsResult<JsRevocableProxy>`. Checked for external callers —> only a type re-export in `mod.rs`, so the cascade is limited to 1 file. Note: The two `JsNativeError::typ()` usages in `from_object()` and `TryFromJs` are intentionally left unchanged (becauze i think these are correct user-facing TypeErrors, not internal implementation failures.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3241
Converts all 13 panics in
jsproxy.rstoEngineError::Panicusingjs_expectintroduced in #4828.build()andbuild_revocable()return types changed fromJsProxy/JsRevocableProxytoJsResult<JsProxy>/JsResult<JsRevocableProxy>.Checked for external callers —> only a type re-export in
mod.rs, sothe cascade is limited to 1 file.
Note: The two
JsNativeError::typ()usages infrom_object()andTryFromJsare intentionally left unchanged (becauze i think these are correctuser-facing TypeErrors, not internal implementation failures.)