fix(ci): replace deprecated wasm-pack-action with cargo install#4872
Merged
jedel1043 merged 2 commits intoboa-dev:mainfrom Mar 6, 2026
Merged
Conversation
Fixes boa-dev#3912 jetli/wasm-pack-action@v0.4.0 uses deprecated Node 16, causing warnings when publishing releases. Replacing it with 'cargo install wasm-pack' eliminates the deprecation warning and relies on official tooling from crates.io. Made-with: Cursor
Test262 conformance changes
Tested main commit: |
Contributor
Author
|
@nekevss can you review my PR |
jedel1043
reviewed
Mar 6, 2026
.github/workflows/release.yml
Outdated
| uses: jetli/wasm-pack-action@v0.4.0 | ||
| with: | ||
| version: 'latest' | ||
| run: cargo install wasm-pack |
Member
There was a problem hiding this comment.
Can you use baptiste0928/cargo-install instead? We use that action widely because it automatically caches the compiled binaries.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4872 +/- ##
===========================================
+ Coverage 47.24% 57.27% +10.02%
===========================================
Files 476 556 +80
Lines 46892 60642 +13750
===========================================
+ Hits 22154 34731 +12577
- Misses 24738 25911 +1173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@jedel1043 please have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ci): Replace deprecated wasm-pack-action with cargo install
Fixes #3912
Summary
This pull request resolves the Node.js deprecation warning emitted during Boa's release publishing workflow. The
npm_publishjob currently usesjetli/wasm-pack-action@v0.4.0, which runs on Node.js 16—a version deprecated by GitHub Actions. This change replaces that action with the officialcargo install wasm-packmethod, eliminating the deprecation warning and aligning the workflow with supported tooling.Problem
When a release is published, the
npm_publishjob produces the following warning:While GitHub indicates it will force the action to Node 20, the warning clutters CI output and signals reliance on unmaintained infrastructure. The action has not been updated to explicitly support Node 20.
Solution
Replace the third-party
jetli/wasm-pack-actionwith a directcargo install wasm-packstep. This approach:Changes
uses: jetli/wasm-pack-action@v0.4.0withversion: 'latest'run: cargo install wasm-packNo other steps in the
npm_publishjob are modified. The build command, npm publishing logic, and Node.js setup remain unchanged.Trade-offs
cargo installadds approximately 2–3 minutes to the job compared to downloading a pre-built binary. Release publishes are infrequent (typically a few times per release cycle), so this is an acceptable trade-off for cleaner, more maintainable CI.Testing
Checklist