Skip to content

fix(ci): replace deprecated wasm-pack-action with cargo install#4872

Merged
jedel1043 merged 2 commits intoboa-dev:mainfrom
tkshsbcue:fix/node-deprecation-release-workflow
Mar 6, 2026
Merged

fix(ci): replace deprecated wasm-pack-action with cargo install#4872
jedel1043 merged 2 commits intoboa-dev:mainfrom
tkshsbcue:fix/node-deprecation-release-workflow

Conversation

@tkshsbcue
Copy link
Copy Markdown
Contributor

fix(ci): Replace deprecated wasm-pack-action with cargo install

Fixes #3912


Summary

This pull request resolves the Node.js deprecation warning emitted during Boa's release publishing workflow. The npm_publish job currently uses jetli/wasm-pack-action@v0.4.0, which runs on Node.js 16—a version deprecated by GitHub Actions. This change replaces that action with the official cargo install wasm-pack method, eliminating the deprecation warning and aligning the workflow with supported tooling.

Problem

When a release is published, the npm_publish job produces the following warning:

The following actions uses Node.js version which is deprecated and will be forced to run on node20: 
jetli/wasm-pack-action@v0.4.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default

While GitHub indicates it will force the action to Node 20, the warning clutters CI output and signals reliance on unmaintained infrastructure. The action has not been updated to explicitly support Node 20.

Solution

Replace the third-party jetli/wasm-pack-action with a direct cargo install wasm-pack step. This approach:

  • Eliminates the deprecation warning — No Node 16 dependency
  • Uses official tooling — wasm-pack is installed from crates.io via Cargo
  • Reduces external dependencies — No reliance on third-party actions that may become unmaintained
  • Maintains correctness — Same wasm-pack binary used for the build; behavior is unchanged

Changes

Before After
uses: jetli/wasm-pack-action@v0.4.0 with version: 'latest' run: cargo install wasm-pack

No other steps in the npm_publish job are modified. The build command, npm publishing logic, and Node.js setup remain unchanged.

Trade-offs

  • Build time: cargo install adds approximately 2–3 minutes to the job compared to downloading a pre-built binary. Release publishes are infrequent (typically a few times per release cycle), so this is an acceptable trade-off for cleaner, more maintainable CI.

Testing

  • Workflow YAML has been validated
  • No changes to build or publish logic; existing release process is preserved

Checklist

Fixes boa-dev#3912

jetli/wasm-pack-action@v0.4.0 uses deprecated Node 16, causing
warnings when publishing releases. Replacing it with
'cargo install wasm-pack' eliminates the deprecation warning
and relies on official tooling from crates.io.

Made-with: Cursor
@tkshsbcue tkshsbcue requested a review from a team as a code owner March 5, 2026 06:46
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 49,666 49,666 0
Ignored 2,284 2,284 0
Failed 1,013 1,013 0
Panics 0 0 0
Conformance 93.77% 93.77% 0.00%

Tested main commit: c37ba1b2a1f5d19f45bfe717567c2b1ad15afca4
Tested PR commit: 83e66e0d8bd9100826acc2108c404696f5f57303
Compare commits: c37ba1b...83e66e0

@tkshsbcue
Copy link
Copy Markdown
Contributor Author

@nekevss can you review my PR

uses: jetli/wasm-pack-action@v0.4.0
with:
version: 'latest'
run: cargo install wasm-pack
Copy link
Copy Markdown
Member

@jedel1043 jedel1043 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use baptiste0928/cargo-install instead? We use that action widely because it automatically caches the compiled binaries.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedel1043 just made those changes!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.27%. Comparing base (6ddc2b4) to head (83e66e0).
⚠️ Report is 763 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4872       +/-   ##
===========================================
+ Coverage   47.24%   57.27%   +10.02%     
===========================================
  Files         476      556       +80     
  Lines       46892    60642    +13750     
===========================================
+ Hits        22154    34731    +12577     
- Misses      24738    25911     +1173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tkshsbcue
Copy link
Copy Markdown
Contributor Author

@jedel1043 please have a look

Copy link
Copy Markdown
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks

@jedel1043 jedel1043 added this pull request to the merge queue Mar 6, 2026
Merged via the queue into boa-dev:main with commit dd1abf0 Mar 6, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bump node version in the npm action

2 participants