Do not pull default engine features into runtime

[tomasol]

The default features include temporal which cannot be deactivated with the previous configuration.

[github-actions]

Test262 conformance changes

Test result	main count	PR count	difference
Total	52,963	52,963	0
Passed	49,666	49,666	0
Ignored	2,284	2,284	0
Failed	1,013	1,013	0
Panics	0	0	0
Conformance	93.77%	93.77%	0.00%

Tested main commit: 5cbf23323e1be945022cd1e6332cbacc22e9a2c8
Tested PR commit: 880c0c5bd0a96d8e14942b6229d6f808054cd2f1
Compare commits: 5cbf233...880c0c5

[nekevss]

What is the use case for not wanting to include default features into the runtime?

Also, if we are turning it off by default, shouldn't provide corresponding feature flags to turn them back on?

[tomasol]

What is the use case for not wanting to include default features into the runtime?

I want to be able to disable certain engine features like temporal for smaller binary size. This is possible if just depending on engine, however runtime is currently dependent on all default engine features as well, so they are pulled anyway.

Also, if we are turning it off by default, shouldn't provide corresponding feature flags to turn them back on?

I've re-enabled the engine's default features as default features of runtime, so existing users should see no change. Only users who explicitly disable runtime's default features gain the ability to also exclude temporal etc.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.12%. Comparing base (6ddc2b4) to head (880c0c5).
⚠️ Report is 756 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4879      +/-   ##
==========================================
+ Coverage   47.24%   57.12%   +9.87%     
==========================================
  Files         476      555      +79     
  Lines       46892    60599   +13707     
==========================================
+ Hits        22154    34616   +12462     
- Misses      24738    25983    +1245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jedel1043]

I agree with this change. boa_runtime should be a reusable library of components that folks can use to build their runtimes first, and a "runtime" second. Not bundling unnecessary features by default seems to align with our first target.

[nekevss]

I'm for this changes as well.

Part of the reason why I'm for the same change in the engine too. It's just given me pause because I'm curious if there's a way to ship temporal without any of the data compiled in the binary. But that can be solved by feature flagging the default provider.