Implement validator for JS syntax in CLI#4911
Merged
jedel1043 merged 2 commits intoboa-dev:mainfrom Mar 9, 2026
Merged
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4911 +/- ##
===========================================
+ Coverage 47.24% 58.06% +10.82%
===========================================
Files 476 557 +81
Lines 46892 61096 +14204
===========================================
+ Hits 22154 35478 +13324
- Misses 24738 25618 +880 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bc94d26 to
7c704aa
Compare
|
Hi @jedel1043 , I noticed that PR #4888 has already been merged. |
7c704aa to
a511c26
Compare
a511c26 to
ed8d165
Compare
hansl
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, when being on REPL mode, you could type something that is invalid Javascript but contains unclosed brackets, then press enter and the REPL would happily accept your input. For example:
Note that it prints an error only until the bracket is closed, even if there was already a syntax error from line 1.
What this does is to make it such that the CLI gives feedback when pressing enter if the input is already invalid JS: