feat(engine): add JsArrayBuffer::to_vec for copying bytes#4976
Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom Mar 9, 2026
Merged
feat(engine): add JsArrayBuffer::to_vec for copying bytes#4976jedel1043 merged 1 commit intoboa-dev:mainfrom
JsArrayBuffer::to_vec for copying bytes#4976jedel1043 merged 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
6c1d222 to
ee8be0b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4976 +/- ##
===========================================
+ Coverage 47.24% 58.35% +11.11%
===========================================
Files 476 556 +80
Lines 46892 61153 +14261
===========================================
+ Hits 22154 35688 +13534
- Misses 24738 25465 +727 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @jedel1043 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #4974.
It changes the following:
JsArrayBuffer::to_vec(&self) -> Option<Vec<u8>>helper to copy buffer contents into a freshVec<u8>while returningNonewhen the buffer has been detachedJsArrayBuffer::to_vec, including both normal and detached casesarray_buffer_to_vec_roundtrip_and_detachandarray_buffer_to_vec_empty) to cover round-trip, detach, and empty-buffer behaviorTesting:
cargo test -p boa_engine(including the new unit tests and doctest)