feat(promise): implement Promise.allKeyed and Promise.allSettledKeyed#4996
Merged
jedel1043 merged 9 commits intoboa-dev:mainfrom Mar 13, 2026
Merged
Conversation
Implement the TC39 await-dictionary proposal (Promise.allKeyed and Promise.allSettledKeyed) with shared PerformPromiseAllKeyed algorithm. - Add Promise.allKeyed() and Promise.allSettledKeyed() static methods - Implement PerformPromiseAllKeyed with KeyedVariant enum (All/AllSettled) - Add CreateKeyedPromiseCombinatorResultObject helper - Bump CONSTRUCTOR_STORAGE_SLOTS from 10 to 12 - Remove await-dictionary from ignored features in test262_config.toml
dc295b9 to
455b78a
Compare
Test262 conformance changes
Fixed tests (12):Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4996 +/- ##
===========================================
+ Coverage 47.24% 58.45% +11.21%
===========================================
Files 476 559 +83
Lines 46892 61609 +14717
===========================================
+ Hits 22154 36016 +13862
- Misses 24738 25593 +855 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
All of this needs to be gated behind the |
jedel1043
reviewed
Mar 13, 2026
jedel1043
approved these changes
Mar 13, 2026
Member
jedel1043
left a comment
There was a problem hiding this comment.
Thank you for adding this feature!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request closes the 12 ignored
await-dictionaryTest262 tests.It changes the following:
Promise.allKeyed()static method per the TC39 await-dictionary proposalPromise.allSettledKeyed()static method per the TC39 await-dictionary proposalPerformPromiseAllKeyedalgorithm withKeyedVariantenum (All/AllSettled)CreateKeyedPromiseCombinatorResultObjecthelper functionCONSTRUCTOR_STORAGE_SLOTSfrom 10 to 12"await-dictionary"from ignored features intest262_config.toml