Skip to content

feat(vm): explicit call frame boundaries#5010

Merged
jedel1043 merged 4 commits intoboa-dev:mainfrom
ashddev:feature/4986-explicit-call-frame-boundaries
Mar 12, 2026
Merged

feat(vm): explicit call frame boundaries#5010
jedel1043 merged 4 commits intoboa-dev:mainfrom
ashddev:feature/4986-explicit-call-frame-boundaries

Conversation

@ashddev
Copy link
Contributor

@ashddev ashddev commented Mar 12, 2026

This Pull Request fixes/closes #4986

It changes the following:

  • Trace a new call frame whenever a new frame is pushed onto the stack.
  • Ensure each code block’s compiled output is printed only once.

@ashddev ashddev requested a review from a team as a code owner March 12, 2026 11:21
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 49,901 49,901 0
Ignored 2,222 2,222 0
Failed 840 840 0
Panics 0 0 0
Conformance 94.22% 94.22% 0.00%

Tested main commit: a49348586d90b790936dc6ab651da6aff3f60e67
Tested PR commit: 1b5b2981ab4ad4481b62b96dc8a94a6e3d465d49
Compare commits: a493485...1b5b298

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.34%. Comparing base (6ddc2b4) to head (1b5b298).
⚠️ Report is 809 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/vm/mod.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5010       +/-   ##
===========================================
+ Coverage   47.24%   58.34%   +11.09%     
===========================================
  Files         476      559       +83     
  Lines       46892    61395    +14503     
===========================================
+ Hits        22154    35818    +13664     
- Misses      24738    25577      +839     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043
Copy link
Member

Before:

image

After:

image

Looks very clean!

@jedel1043 jedel1043 added C-CLI Issues and PRs related to the Boa command line interface. C-VM Issues and PRs related to the Boa Virtual Machine. labels Mar 12, 2026
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@jedel1043 jedel1043 added this pull request to the merge queue Mar 12, 2026
Merged via the queue into boa-dev:main with commit 55786ce Mar 12, 2026
19 checks passed
MayankRaj435 pushed a commit to MayankRaj435/boa that referenced this pull request Mar 12, 2026
This Pull Request fixes/closes
[boa-dev#4986](boa-dev#4986)

It changes the following:
- Trace a new call frame whenever a new frame is pushed onto the stack.
- Ensure each code block’s compiled output is printed only once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-CLI Issues and PRs related to the Boa command line interface. C-VM Issues and PRs related to the Boa Virtual Machine.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make call frame boundaries explicit in VM trace

2 participants