feat(error): harden JsNativeError public API surface#5012
Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom Mar 12, 2026
Merged
feat(error): harden JsNativeError public API surface#5012jedel1043 merged 1 commit intoboa-dev:mainfrom
jedel1043 merged 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5012 +/- ##
===========================================
+ Coverage 47.24% 58.39% +11.14%
===========================================
Files 476 559 +83
Lines 46892 61406 +14514
===========================================
+ Hits 22154 35855 +13701
- Misses 24738 25551 +813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MayankRaj435
pushed a commit
to MayankRaj435/boa
that referenced
this pull request
Mar 12, 2026
This Pull Request fixes/closes boa-dev#4981. It changes the following: * Make `JsNativeError::kind` a private field instead of `pub`. * Add a `JsNativeError::kind(&self) -> &JsNativeErrorKind` accessor as the stable API. * Update internal usages (engine tests, runtime tests, URI tests, tester helpers, docs/examples) to call `kind()` instead of reading the field directly. Testing: * `cargo test -p boa_engine`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #4981.
It changes the following:
JsNativeError::kinda private field instead ofpub.JsNativeError::kind(&self) -> &JsNativeErrorKindaccessor as the stable API.kind()instead of reading the field directly.Testing:
cargo test -p boa_engine