You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds URLSearchParams and wires up URL.searchParams.
This also fixes the constructor path for iterable inputs, handles explicit undefined correctly in the two-argument has() and delete() overloads, adds runtime coverage, and re-enables the skipped URL WPT case.
Tests:
cargo test -p boa_runtime --lib
cargo test --manifest-path tests/wpt/Cargo.toml url -- --nocapture
❌ Patch coverage is 89.68481% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.77%. Comparing base (6ddc2b4) to head (de17de0). ⚠️ Report is 896 commits behind head on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-EnhancementNew feature or requestC-BuiltinsPRs and Issues related to builtins/intrinsicsC-RuntimeIssues and PRs related to Boa's runtime featuresC-TestsIssues and PRs related to the tests.Waiting On AuthorWaiting on PR changes from the author
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4743.
Adds
URLSearchParamsand wires upURL.searchParams.This also fixes the constructor path for iterable inputs, handles explicit
undefinedcorrectly in the two-argumenthas()anddelete()overloads, adds runtime coverage, and re-enables the skipped URL WPT case.Tests:
cargo test -p boa_runtime --libcargo test --manifest-path tests/wpt/Cargo.toml url -- --nocapturecargo clippy -p boa_runtime --all-features --all-targets -- -D warnings