Implement Temporal.Duration.prototype.toLocaleString#5091
Open
SKM2227229725 wants to merge 4 commits intoboa-dev:mainfrom
Open
Implement Temporal.Duration.prototype.toLocaleString#5091SKM2227229725 wants to merge 4 commits intoboa-dev:mainfrom
SKM2227229725 wants to merge 4 commits intoboa-dev:mainfrom
Conversation
SKM2227229725
requested review from
a team,
jasonwilliams,
jedel1043 and
nekevss
as code owners
github-actions
bot
added
Waiting On Review
jedel1043
reviewed
Mar 15, 2026
Author
There was a problem hiding this comment.
Thanks for pointing that out. I’ve removed the unrelated README change from the PR.
jedel1043
reviewed
Mar 15, 2026
Comment on lines
+1163
to
+1174
| let duration_format_prop = intl_obj.get(js_string!("DurationFormat"), context)?; | ||
|
|
||
| // Check if DurationFormat exists and is a constructor. | ||
| if let Some(constructor) = duration_format_prop.as_constructor() { | ||
| // Construct: new Intl.DurationFormat(locales, options) | ||
| let formatter = constructor.construct(&[locales.clone(), options.clone()], context)?; | ||
|
|
||
| // Get the format method. | ||
| let format_method = formatter.get(js_string!("format"), context)?; | ||
| if let Some(format_fn) = format_method.as_callable() { | ||
| // Call format with the duration object. | ||
| return format_fn.call(&formatter.into(), &[this.clone()], context); |
Member
There was a problem hiding this comment.
DurationFormat doesn't exist in our Intl implementation, so this will always fail. Please validate what your LLM generates before pushing changes.
Author
There was a problem hiding this comment.
@jedel1043 Thanks for the feedback! You're right, Intl.DurationFormat is not currently implemented in Boa.
I'll update the implementation to remove that usage and instead fall back to the existing toString behavior until full Intl support is available.
github-actions
bot
added
the
Waiting On Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5088
Summary
Implements
Temporal.Duration.prototype.toLocaleStringwith support for bothintland non-intlbuild configurations.Changes
Method Implementation: Added
to_locale_stringto theDurationstruct.Intl Integration:
intlis enabled, the implementation dynamically usesIntl.DurationFormatfrom the global object to format the duration.intlis disabled, it falls back to the ISO-8601 string representation usingas_temporal_string.Safety: Uses safe property access and type checking to prevent panics if the global
Intlobject is modified.Registration: Registers the method in the
Durationprototype during intrinsic initialization.Verification
localesandoptionsarguments.thisvalue.cargo check.