feat(intl): implement Temporal.Instant.prototype.toLocaleString#5096
Open
JkrishnaD wants to merge 1 commit intoboa-dev:mainfrom
Open
feat(intl): implement Temporal.Instant.prototype.toLocaleString#5096JkrishnaD wants to merge 1 commit intoboa-dev:mainfrom
JkrishnaD wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5096 +/- ##
===========================================
+ Coverage 47.24% 59.10% +11.85%
===========================================
Files 476 563 +87
Lines 46892 62667 +15775
===========================================
+ Hits 22154 37037 +14883
- Misses 24738 25630 +892 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@jedel1043 this pr is just a base and waiting for the #5080 get merged as in that we get |
Member
|
Marking as blocked on #5080 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #5087.
It changes the following:
thisis aTemporal.Instantobjectlocalesandoptionsarguments (previously ignored with_)to_ixdtf_string_with_provideruntilIntl.DateTimeFormatintegration is completeTODO: Update for ECMA-402 compliancecomment.Full
Intl.DateTimeFormatintegration (steps 3 & 4) is blocked on #5080, which addsformat_date_time_localeandFormatDefaults::All. Once that merges, this can be updated to use that function directly.Spec: https://tc39.es/proposal-temporal/#sec-temporal.instant.tolocalestring