fix(cli): clamp setTimeout to 1ms#5309
Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom Apr 9, 2026
Merged
Conversation
CLI's custom executor can starve the event loop when doing a setTimeout(fn, 0) loop. This happens during tests like test/built-ins/Atomics/waitAsync/bigint/true-for-timeout.js Solution: clamp the delay to 1ms minimum (same as Node.js). Fixes boa-dev#5308
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5309 +/- ##
===========================================
+ Coverage 47.24% 59.69% +12.45%
===========================================
Files 476 589 +113
Lines 46892 63665 +16773
===========================================
+ Hits 22154 38006 +15852
- Misses 24738 25659 +921 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI's custom executor can starve the event loop when doing a
setTimeout(fn, 0)loop. This happens during tests liketest/built-ins/Atomics/waitAsync/bigint/true-for-timeout.jsSolution: clamp the delay to 1ms minimum (same as Node.js).
Fixes #5308