Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
TaggedPtr::as_ptrmethod was previously using XOR to remove the tag bit , this incorrectly corrupted untagged pointers by tagging them. Fixed it to useaddr & !MASKto safely clear the tag bit without modifying untagged addresses.run_drop_checknever caught this bug because the function iterates backwards and early returns false immediately on encountering an untagged pointer.I guess this should be fixed to ensure the correctness of
as_ptr()functionAdded test
as_ptr_clears_not_flips_tag_bit()to verify the failure, the test failed without the fixbefore the fix:
