Update ZonedDateTime module and API #557
Conversation
| zdt.to_plain_date() | ||
| .map(|x| Box::new(Self(x))) | ||
| .map_err(Into::into) | ||
| Ok(Box::new(Self(zdt.to_plain_date()))) |
There was a problem hiding this comment.
suggestion: change the return type here and below while you're at it, unless you think we want to retain the ability to have this be an error.
Upgrading v8 across this is mildly annoying but fine, especially when there's time to prepare for it
What I don't want is breakages either happening right before a release (takes a few days to prep for) or there being so many of them accumulated between releases that V8 has to carry an unweildy number of ifdefs.
I think we're fine on both counts, here.
There was a problem hiding this comment.
I left the return type a Result here do to the zdt_from_epoch_ms_with_provider that's called above.
Admittedly, I didn't majorly dive down that codepath here. Primarily because if we are calling anything that requires a provider, then it's going to retain it's Result return unless we remove the use of the provider.
This PR is a general audit of the ZonedDateTime built-in.
It completes a variety of changes that would be considered breaking in order to prep for 0.1.
with_calendarinfallible