Skip to content

Set YearMonth's day to 1 in calendar space when diffing#640

Merged
nekevss merged 1 commit intoboa-dev:mainfrom
Manishearth:yearmonth-diff-chinese
Nov 27, 2025
Merged

Set YearMonth's day to 1 in calendar space when diffing#640
nekevss merged 1 commit intoboa-dev:mainfrom
Manishearth:yearmonth-diff-chinese

Conversation

@Manishearth
Copy link
Contributor

intl402/Temporal/PlainYearMonth/prototype/since/chinese-calendar-dates
intl402/Temporal/PlainYearMonth/prototype/since/dangi-calendar-dates

@Manishearth Manishearth requested a review from nekevss November 25, 2025 22:39
@Manishearth Manishearth force-pushed the yearmonth-diff-chinese branch from 33114f9 to dd89898 Compare November 25, 2025 22:40
@Manishearth Manishearth changed the title Set YearMonth's day to 1 in calendar space, not ISO space, before diffing Set YearMonth's day to 1 in calendar space when diffing Nov 25, 2025
@Manishearth Manishearth force-pushed the yearmonth-diff-chinese branch from dd89898 to afec71a Compare November 25, 2025 22:50
aarongable pushed a commit to chromium/chromium that referenced this pull request Nov 25, 2025
…ffing

Uplift boa-dev/temporal#640

Bug: 401065166,463269833
Change-Id: I62d593eef513e31fb4b7c39293c61c3c4e81aef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204673
Commit-Queue: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1550124}
@nekevss nekevss merged commit 3ebb0d4 into boa-dev:main Nov 27, 2025
8 checks passed
@Manishearth Manishearth deleted the yearmonth-diff-chinese branch November 27, 2025 18:31
mohd-akram pushed a commit to gsource-mirror/chromium-src-third_party-rust that referenced this pull request Jan 9, 2026
…ffing

Uplift boa-dev/temporal#640

Bug: 401065166,463269833
Change-Id: I62d593eef513e31fb4b7c39293c61c3c4e81aef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204673
Commit-Queue: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1550124}
NOKEYCHECK=True
GitOrigin-RevId: bc9d0d25216b8c493fa563c8a61976021036839a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants