EventID has no nodeId but it is being used.

[Poikilos]

This looks like maybe a type-o carried over from reusing code from the NodeID constructor. The EventID constructor has this code and it appears incorrect since EventID has no nodeId. What should this look like?

        elif isinstance(data, EventID):
            self.eventId = data.nodeId

probably change to self.eventId = data.eventId

but I think EventID and NodeID would be less confusing to read and use if we change EventID's eventID and NodeID's nodeID to just self.value, since the type is int not the parent class type as the name implies in other parts of the code and typical conventions. Let me know your thoughts.

[bobjacobsen]

@Poikilos A good catch! Looks like a copy&paste error on my part. Do you have a branch with this fixed? If not, I can make a quick PR for it.

[Poikilos]

Ok, I was in a game jam last week but it looks good. I can make a PR with the change to "value" which can help indicate the type is int after the PR is merged or I can create a separate PR.

[bobjacobsen]

I merged this PR. If you could PR an update to "value", that would be great.

[Poikilos]

Yes, I am working on that and UTF-8.