Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions 0-0-intro/src/main/java/com/bobocode/intro/Introduction.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import com.bobocode.util.ExerciseNotCompletedException;

import java.util.Base64;

/**
* Welcome! This is an introduction class that will show you a simple example of Bobocode exercise.
* <p>
Expand All @@ -24,7 +26,7 @@ public class Introduction {
* @return "The key to efficient learning is practice!"
*/
public String getWelcomeMessage() {
throw new ExerciseNotCompletedException(); // todo: refactor it to return a message according to javadoc
return "The key to efficient learning is practice!";
}

/**
Expand All @@ -40,6 +42,6 @@ public String getWelcomeMessage() {
*/
public String encodeMessage(String message) {
// todo: switch to branch "completed" in order to see how it should be implemented
throw new ExerciseNotCompletedException();
return Base64.getEncoder().encodeToString(message.getBytes());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,18 @@
* <p>
* todo: refactor this class so it uses generic type "T" and run {@link com.bobocode.basics.BoxTest} to verify it
*/
public class Box {
private Object value;
public class Box<T> {
private T value;

public Box(Object value) {
public Box(T value) {
this.value = value;
}

public Object getValue() {
public T getValue() {
return value;
}

public void setValue(Object value) {
public void setValue(T value) {
this.value = value;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
*/
public class BoxDemoApp {
public static void main(String[] args) {
Box intBox = new Box(123);
Box intBox2 = new Box(321);
System.out.println((int) intBox.getValue() + (int) intBox2.getValue());
Box<Integer> intBox = new Box(123);
Box<Integer> intBox2 = new Box(321);
System.out.println(intBox.getValue() + intBox2.getValue());

intBox.setValue(222);
intBox.setValue("abc"); // this should not be allowed
// intBox.setValue("abc"); // this should not be allowed
// the following code will compile, but will throw runtime exception
System.out.println((int) intBox.getValue() + (int) intBox2.getValue());
System.out.println(intBox.getValue() + intBox2.getValue());
}
}
Original file line number Diff line number Diff line change
@@ -1,22 +1,19 @@
package com.bobocode.basics;

import com.bobocode.basics.util.BaseEntity;
import com.bobocode.util.ExerciseNotCompletedException;
import lombok.Data;

import java.io.Serializable;
import java.util.Collection;
import java.util.Comparator;
import java.util.List;
import java.util.Objects;
import java.util.*;
import java.util.function.Predicate;

/**
* {@link CrazyGenerics} is an exercise class. It consists of classes, interfaces and methods that should be updated
* using generics.
* <p>
* TODO: go step by step from top to bottom. Read the java doc, write code and run CrazyGenericsTest to verify your impl
* <p>
* Hint: in some cases you will need to refactor the code, like replace {@link Object} with a generic type. In order
* Hint: in some cases you will need to refactor the code, like replace {link T} with a generic type. In order
* cases you will need to add new fields, create new classes, or add new methods. Always try to read java doc and update
* the code according to it.
* <p><p>
Expand All @@ -33,8 +30,8 @@ public class CrazyGenerics {
* @param <T> – value type
*/
@Data
public static class Sourced { // todo: refactor class to introduce type parameter and make value generic
private Object value;
public static class Sourced<T> {
private T value;
private String source;
}

Expand All @@ -45,11 +42,10 @@ public static class Sourced { // todo: refactor class to introduce type paramete
* @param <T> – actual, min and max type
*/
@Data
public static class Limited {
// todo: refactor class to introduce type param bounded by number and make fields generic numbers
private final Object actual;
private final Object min;
private final Object max;
public static class Limited<T extends Number> {
private final T actual;
private final T min;
private final T max;
}

/**
Expand All @@ -59,8 +55,8 @@ public static class Limited {
* @param <T> – source object type
* @param <R> - converted result type
*/
public interface Converter { // todo: introduce type parameters
// todo: add convert method
public interface Converter<T, R> {
<T, R> R convert(T source);
}

/**
Expand All @@ -70,10 +66,10 @@ public interface Converter { // todo: introduce type parameters
*
* @param <T> – value type
*/
public static class MaxHolder { // todo: refactor class to make it generic
private Object max;
public static class MaxHolder<T extends Comparable<T>> {
private T max;

public MaxHolder(Object max) {
public MaxHolder(T max) {
this.max = max;
}

Expand All @@ -82,11 +78,13 @@ public MaxHolder(Object max) {
*
* @param val a new value
*/
public void put(Object val) {
throw new ExerciseNotCompletedException(); // todo: update parameter and implement the method
public void put(T val) {
if (val.compareTo(max) > 0) {
max = val;
}
}

public Object getMax() {
public T getMax() {
return max;
}
}
Expand All @@ -97,8 +95,8 @@ public Object getMax() {
*
* @param <T> – the type of objects that can be processed
*/
interface StrictProcessor { // todo: make it generic
void process(Object obj);
interface StrictProcessor<T extends Serializable & Comparable<T>> {
void process(T obj);
}

/**
Expand All @@ -108,10 +106,10 @@ interface StrictProcessor { // todo: make it generic
* @param <T> – a type of the entity that should be a subclass of {@link BaseEntity}
* @param <C> – a type of any collection
*/
interface CollectionRepository { // todo: update interface according to the javadoc
void save(Object entity);
interface CollectionRepository<T extends BaseEntity, C extends Collection<T>> {
void save(T entity);

Collection<Object> getEntityCollection();
C getEntityCollection();
}

/**
Expand All @@ -120,7 +118,7 @@ interface CollectionRepository { // todo: update interface according to the java
*
* @param <T> – a type of the entity that should be a subclass of {@link BaseEntity}
*/
interface ListRepository { // todo: update interface according to the javadoc
interface ListRepository<T extends BaseEntity> extends CollectionRepository<T, List<T>> {
}

/**
Expand All @@ -133,7 +131,11 @@ interface ListRepository { // todo: update interface according to the javadoc
*
* @param <E> a type of collection elements
*/
interface ComparableCollection { // todo: refactor it to make generic and provide a default impl of compareTo
interface ComparableCollection<E> extends Collection<E>, Comparable<Collection<?>> {
@Override
default int compareTo(Collection<?> o) {
return Integer.compare(this.size(), o.size());
}
}

/**
Expand All @@ -147,8 +149,7 @@ static class CollectionUtil {
*
* @param list
*/
public static void print(List<Integer> list) {
// todo: refactor it so the list of any type can be printed, not only integers
public static void print(List<?> list) {
list.forEach(element -> System.out.println(" – " + element));
}

Expand All @@ -160,8 +161,13 @@ public static void print(List<Integer> list) {
* @param entities provided collection of entities
* @return true if at least one of the elements has null id
*/
public static boolean hasNewEntities(Collection<BaseEntity> entities) {
throw new ExerciseNotCompletedException(); // todo: refactor parameter and implement method
public static boolean hasNewEntities(Collection<? extends BaseEntity> entities) {
for (BaseEntity baseEntity : entities) {
if (baseEntity.getUuid() == null) {
return true;
}
}
return false;
}

/**
Expand All @@ -173,8 +179,13 @@ public static boolean hasNewEntities(Collection<BaseEntity> entities) {
* @param validationPredicate criteria for validation
* @return true if all entities fit validation criteria
*/
public static boolean isValidCollection() {
throw new ExerciseNotCompletedException(); // todo: add method parameters and implement the logic
public static boolean isValidCollection(Collection<? extends BaseEntity> entities, Predicate<? super BaseEntity> validationPredicate) {
for (BaseEntity entity : entities) {
if (!validationPredicate.test(entity)) {
return false;
}
}
return true;
}

/**
Expand All @@ -187,8 +198,14 @@ public static boolean isValidCollection() {
* @param <T> entity type
* @return true if entities list contains target entity more than once
*/
public static boolean hasDuplicates() {
throw new ExerciseNotCompletedException(); // todo: update method signature and implement it
public static <T extends BaseEntity> boolean hasDuplicates(List<T> entities, T targetEntity) {
if (entities.isEmpty() || targetEntity == null) return false;
int count = 0;
for (BaseEntity e : entities) {
if (e.getUuid().equals(targetEntity.getUuid())) count++;
if (e.getUuid().equals(targetEntity.getUuid()) && count > 1) return true;
}
return false;
}

/**
Expand All @@ -200,7 +217,21 @@ public static boolean hasDuplicates() {
* @param <T> type of elements
* @return optional max value
*/
// todo: create a method and implement its logic manually without using util method from JDK

public static <T> Optional<T> findMax(Iterable<T> elements, Comparator<? super T> comparator) {
var iterator = elements.iterator();
if (!iterator.hasNext()) {
return Optional.empty();
}
var max = iterator.next();
while (iterator.hasNext()) {
var element = iterator.next();
if (comparator.compare(element, max) > 0) {
max = element;
}
}
return Optional.of(max);
}

/**
* findMostRecentlyCreatedEntity is a generic util method that accepts a collection of entities and returns the
Expand All @@ -214,7 +245,11 @@ public static boolean hasDuplicates() {
* @param <T> entity type
* @return an entity from the given collection that has the max createdOn value
*/
// todo: create a method according to JavaDoc and implement it using previous method
public static <T extends BaseEntity> T findMostRecentlyCreatedEntity(Collection<T> entities) {
if (entities.isEmpty()) throw new NoSuchElementException();

return findMax(entities, CREATED_ON_COMPARATOR).orElseThrow();
}

/**
* An util method that allows to swap two elements of any list. It changes the list so the element with the index
Expand All @@ -228,7 +263,13 @@ public static boolean hasDuplicates() {
public static void swap(List<?> elements, int i, int j) {
Objects.checkIndex(i, elements.size());
Objects.checkIndex(j, elements.size());
throw new ExerciseNotCompletedException(); // todo: complete method implementation
swapper(elements, i, j);
}

private static <T> void swapper(List<T> elements, int i, int j) {
var a = elements.get(i);
elements.set(i, elements.get(j));
elements.set(j, a);
}

}
Expand Down