Relax trait bounds #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove implicit requirements T: Clone + Copy + Default. Fix test that required both `rkyv` and `bytecheck` features, placing the `bytecheck` portion of the test behind a feature flag.
bocharov
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the patch set in this PR, I noticed that the
Clone + Copy + Defaulttrait bounds were added throughout the crate's public interface, including on the structs.C-STRUCT-BOUNDS.I made a pass at removing those bounds where it is trivial to do so. There's probably more that can be done to simplify these bounds.
Also, I noticed that one test required both the
rkyvandbytecheckfeatures to be enabled. Assuming we want these features to remain independent (i.e., not bundled together behind a single feature flag), I moved the portion of the test requiring thebytecheckcrate behind thebytecheckfeature flag.