fix: use acceptor subkey for initiator signing when present. Fixes bodgit/tsig#178#50
Merged
Merged
Conversation
CloudbrokerAz
added a commit
to tfo-apj-demos/terraform-dns-records
that referenced
this pull request
May 19, 2026
3.6.0 bumped bodgit/tsig 1.2.2 -> 1.3.0, which broke GSS-TSIG against Windows AD DNS. Confirmed identical to: hashicorp/terraform-provider-dns#642 bodgit/tsig#178 The acceptor-subkey flag handling in the new GSSAPI wrapper rejects the DC's normally-formed MIC tokens. Fix upstream is bodgit/gssapi#50 (not yet merged/released). Pin constraint: >= 3.4.3, < 3.6.0 - 3.4.3 / 3.5.0 both use tsig v1.2.2 (working) - bumps from 3.5.x will resume automatically once a fixed dns provider release is published above 3.6.0. For investigation context see docs/DNS-GSS-TSIG-INVESTIGATION.md in better-together-vm-lifecycle.
bodgit
force-pushed
the
fix/krb5-mic-token-peer-sub-key
branch
from
484ca18 to
97e7350
Compare
|
coverage: 72.87% (-0.3%) from 73.205% — onno204:fix/krb5-mic-token-peer-sub-key into bodgit:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, MakeSignature only checked for the initiator's own subkey
(ctx.subkey) but never used the peer's subkey (ctx.peerSubkey) for
signing.
This caused Windows AD DNS servers to reject GSS-TSIG signed
DNS updates because the signature was computed with the session key
instead of the acceptor's subkey.
Fixes bodgit/tsig#178
I tested this fix by creating a small wrapper using github.com/bodgit/tsig.
Confirmed without the fix, I got the error
unexpected acceptor flag is not set: expecting a token from the acceptor, not in the initiatorAnd confirmed with the fix implemented, the DNS record got updated on our Windows DNS server and now error was thrown.