Error building on 32-bit platforms

[twpayne]

Firstly, thank you for this project!

I tried to build the latest version for a 32-bit machine and got the following error:

$ GOARCH=386 GOOS=linux go build ./...
# github.com/stangelandcl/ppmd
$HOME/pkg/mod/github.com/stangelandcl/ppmd@v0.1.0/reader.go:25:42: (0xFFFFFFFF - 12 * 3) (untyped int constant 4294967259) overflows int

I know the error is coming from https://github.com/stangelandcl/ppmd, but that project has not been updated in four years, so I figured you'd want to know :)

[bodgit]

Thanks for the bug report. It seems like this is the simplest fix without resorting to changing the package API:

diff --git a/reader.go b/reader.go
index 75e4bdd..df8e466 100644
--- a/reader.go
+++ b/reader.go
@@ -22,7 +22,7 @@ func NewH7zReader(r io.Reader, order, memorySize, uncompressedSize int) (Reader,
        if order < 2 || order > 64 {
                return d, fmt.Errorf("order out of range: %v. must be in [2, 64]", order)
        }
-       if memorySize < (1<<11) || memorySize > (0xFFFFFFFF-12*3) {
+       if memorySize < (1<<11) || uint32(memorySize) > (0xFFFFFFFF-12*3) {
                return d, fmt.Errorf("memory size out of range: %v", memorySize)
        }
        d.uncompressedSize = uncompressedSize

[bodgit]

I've forked the package and applied the above fix so this should fix builds on 32-bit. If/when upstream fix the issue, I'll revert back to their package.

[bodgit]

Upstream have applied the same fix, next release of my package will therefore revert back to tracking upstream.