fix: protect against specially crafted archives setting high AES cycles#448
Open
hobeone wants to merge 1 commit into
Open
fix: protect against specially crafted archives setting high AES cycles#448hobeone wants to merge 1 commit into
hobeone wants to merge 1 commit into
Conversation
hobeone
changed the title
add maxCyclesPower to cap the number of cycles. add tests to validate behavior Cycles setting comes directly from the archive's AES properties byte which could be set to something like cycles=62 which would mean 2^62 ≈ 4.6×10^18 SHA-256 iterations, which would effectively hang the process. Standard 7-zip archives use cycles=19 so setting the cap to 24 gives headroom to the standard while still protecting from a malicious file
|
coverage: 74.979% (+0.2%) from 74.815% — hobeone:aes_protect into bodgit:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add maxCyclesPower to cap the number of cycles.
add tests to validate behavior
Cycles setting comes directly from the archive's AES properties byte
which could be set to something like cycles=62 which would mean 2^62 ≈
4.6×10^18 SHA-256 iterations, which would effectively hang the process.
Standard 7-zip archives use cycles=19 so setting the cap to 24 gives
headroom to the standard while still protecting from a malicious file